Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ko: Change the full link in the document to an inline link. #17059

Merged
merged 1 commit into from
Oct 24, 2019
Merged

ko: Change the full link in the document to an inline link. #17059

merged 1 commit into from
Oct 24, 2019

Conversation

ysyukr
Copy link
Member

@ysyukr ysyukr commented Oct 21, 2019 •
edited
Loading

Change to inline URL for inconsistent full URLs and inline URLs.

following command

grep -r "https \: \ / \ / kubernetes \ .io" content/ko/docs

Changed to inline link except the following list.

  • URLs are mentioned directly in the body
  • release note
  • url to blog
  • url to community
  • Url to be redirected

Changed docs list.

  • /ko/docs/concepts/architecture/nodes

Submitted in PR #16876.

  • /ko/docs/concepts/workloads/pods/pod-overview
  • /ko/docs/reference/glossary/cri
  • /ko/docs/setup/production-environment/windows/user-guide-windows-nodes
  • /ko/docs/tutorials/stateless-application/guestbook-logs-metrics-with-elk

reference

/language ko
from #17058

@ysyukr
Change the full link in the document to an inline link.
886084f 
grep -r "https\:\/\/kubernetes\.io" content/ko/docs
Changed to inline link except the following list.
- URLs are mentioned directly in the body
- release note
- url to blog
- url to community
- Url to be redirected
@k8s-ci-robot
Copy link
Contributor

@ysyukr: The label(s) language/#17058 cannot be applied. These labels are supported: api-review, community/discussion, community/maintenance, community/question, cuj/build-train-deploy, cuj/multi-user, platform/aws, platform/azure, platform/gcp, platform/minikube, platform/other

In response to this:

Change to inline URL for inconsistent full URLs and inline URLs.

following command

grep -r "https \: \ / \ / kubernetes \ .io" content/ko/docs

Changed to inline link except the following list.

  • URLs are mentioned directly in the body
  • release note
  • url to blog
  • url to community
  • Url to be redirected

Changed docs list.

  • /ko/docs/concepts/architecture/nodes

Submitted in PR #16876.

  • /ko/docs/concepts/workloads/pods/pod-overview
  • /ko/docs/reference/glossary/cri
  • /ko/docs/setup/production-environment/windows/user-guide-windows-nodes
  • /ko/docs/tutorials/stateless-application/guestbook-logs-metrics-with-elk

reference

/language
from #17058

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/ko Issues or PRs related to Korean language labels Oct 21, 2019
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Oct 21, 2019
@ysyukr ysyukr changed the title Change the full link in the document to an inline link. ko: Change the full link in the document to an inline link. Oct 21, 2019
@netlify
Copy link

netlify bot commented Oct 21, 2019

Deploy preview for k8s-dev-ko ready!

Built with commit 886084f

https://deploy-preview-17059--k8s-dev-ko.netlify.com

seokho-son
seokho-son reviewed Oct 22, 2019
View reviewed changes
Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysyukr 컨트리뷰션 감사합니다 !!
해당 건은 Bug fix를 위한 PR인 것 같습니다.
다만, 현재 수정 내용은 master의 영문 원문과 일관성 유지 차원에서 한글화 작업 브랜치에서만 처리하는 것이 조금 까다로운 것 같습니다.
혹시 master의 영문에서도 bug fix가 가능하신지요? (혹시 이미 PR을 올리셨나요? ^^)

content/ko/docs/reference/glossary/cri.md
@@ -2,7 +2,7 @@
title: 컨테이너 런타임 인터페이스(Container runtime interface, CRI)
id: cri
date: 2019-03-07
full_link: https://kubernetes.io/docs/concepts/overview/components/#container-runtime
full_link: /docs/concepts/overview/components/#container-runtime
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outdated 된 문서인 것 같습니다. 원문(dev-1.16.ko.3)을 찾아보니 아래와 같이 변경되어 있네요.

Suggested change
full_link: /docs/concepts/overview/components/#container-runtime
full_link: /docs/concepts/extend-kubernetes/compute-storage-net/network-plugins/#cni

date: 2018-05-25
full_link: /docs/concepts/extend-kubernetes/compute-storage-net/network-plugins/#cni
short_description: >

content/ko/docs/concepts/workloads/pods/pod-overview.md Show resolved Hide resolved
content/ko/docs/setup/production-environment/windows/user-guide-windows-nodes.md Show resolved Hide resolved
@seokho-son
Copy link
Member

/assign @seokho-son

@seokho-son
Copy link
Member

Master에 #17057 PR을 확인하였습니다. 해당 PR이 merge되는 것을 보고 처리하도록 하겠습니다 :)

@ysyukr
Copy link
Member Author

ysyukr commented Oct 22, 2019

@seokho-son 넵 :)

@seokho-son
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit 24ec007 into kubernetes:dev-1.16-ko.3 Oct 24, 2019
gochist added a commit that referenced this pull request Oct 24, 2019
@ysyukr @gochist @seokho-son
Third Korean l10n work for release-1.16
6973002 
Update file outdated korean docs in dev-1.16-ko.3. (#16876)
Translate concepts/architecture/controller.md in Korean (#16889)
Change the full link in the document to an inline link. (#17059)
Add English-Korean translation glossary (#16664)

Co-Authored-By: Yuk, Yongsu <[email protected]>
Co-Authored-By: June Yi <[email protected]>
Co-Authored-By: Seokho Son <[email protected]>
k8s-ci-robot pushed a commit that referenced this pull request Oct 25, 2019
@gochist @ysyukr
@seokho-son @k8s-ci-robot
Third Korean l10n work for release-1.16 (#17168)
ff5d03a 
Update file outdated korean docs in dev-1.16-ko.3. (#16876)
Translate concepts/architecture/controller.md in Korean (#16889)
Change the full link in the document to an inline link. (#17059)
Add English-Korean translation glossary (#16664)

Co-Authored-By: Yuk, Yongsu <[email protected]>
Co-Authored-By: June Yi <[email protected]>
Co-Authored-By: Seokho Son <[email protected]>
@ysyukr ysyukr deleted the ko-docs-url-fix branch October 25, 2019 22:01
@ysyukr ysyukr mentioned this pull request Oct 28, 2019
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seokho-son seokho-son seokho-son left review comments

@claudiajkang claudiajkang Awaiting requested review from claudiajkang

@ianychoi ianychoi Awaiting requested review from ianychoi

Assignees

@seokho-son seokho-son

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ysyukr @k8s-ci-robot @seokho-son