Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Outdated files in dev-1.17-ko.4 branch. #19002

Merged
merged 2 commits into from
Feb 14, 2020
Merged

Update to Outdated files in dev-1.17-ko.4 branch. #19002

merged 2 commits into from
Feb 14, 2020

Conversation

ysyukr
Copy link
Member

@ysyukr ysyukr commented Feb 6, 2020

36 out of 40 files to be modified

  • content/ko/docs/concepts/architecture/cloud-controller.md
  • content/ko/docs/concepts/containers/images.md
  • content/ko/docs/concepts/containers/runtime-class.md
  • content/ko/docs/concepts/overview/components.md
  • content/ko/docs/concepts/overview/kubernetes-api.md
  • content/ko/docs/concepts/overview/working-with-objects/field-selectors.md

번역시 의미가 동일하여 미반영

  • content/ko/docs/concepts/services-networking/connect-applications-service.md
  • content/ko/docs/concepts/services-networking/endpoint-slices.md
  • content/ko/docs/concepts/services-networking/ingress-controllers.md
  • content/ko/docs/concepts/services-networking/service.md
  • content/ko/docs/concepts/workloads/controllers/replicaset.md
  • content/ko/docs/concepts/workloads/pods/ephemeral-containers.md
  • content/ko/docs/concepts/workloads/pods/pod-lifecycle.md
  • content/ko/docs/contribute/style/write-new-topic.md
  • content/ko/docs/reference/glossary/cluster.md
  • content/ko/docs/reference/glossary/container-runtime.md
  • content/ko/docs/reference/glossary/kube-controller-manager.md
  • content/ko/docs/reference/glossary/kube-scheduler.md
  • content/ko/docs/reference/glossary/pod-lifecycle.md
  • content/ko/docs/reference/glossary/service-account.md

namespace의 중복단어 삭제이지만, 한글 문서는 중복이 없어 미반영

  • content/ko/docs/reference/issues-security/security.md
  • content/ko/docs/reference/kubectl/cheatsheet.md
  • content/ko/docs/setup/_index.md
  • content/ko/docs/setup/best-practices/certificates.md

#18709 에서 반영됨

  • content/ko/docs/setup/best-practices/node-conformance.md
  • content/ko/docs/setup/learning-environment/minikube.md
  • content/ko/docs/setup/production-environment/container-runtimes.md
  • content/ko/docs/setup/production-environment/tools/kops.md
  • content/ko/docs/setup/production-environment/windows/user-guide-windows-nodes.md

#18272 에서 반영됨

  • content/ko/docs/tasks/administer-cluster/network-policy-provider/cilium-network-policy.md
  • content/ko/docs/tasks/debug-application-cluster/resource-metrics-pipeline.md
  • content/ko/docs/tasks/manage-kubernetes-objects/declarative-config.md
  • content/ko/docs/tasks/manage-kubernetes-objects/imperative-config.md
  • content/ko/docs/tasks/run-application/horizontal-pod-autoscale-walkthrough.md
  • content/ko/docs/tasks/run-application/horizontal-pod-autoscale.md
  • content/ko/docs/tutorials/hello-minikube.md
  • content/ko/docs/tutorials/kubernetes-basics/create-cluster/cluster-intro.html
  • content/ko/docs/tutorials/stateful-application/mysql-wordpress-persistent-volume.md
  • content/ko/examples/minikube/Dockerfile
  • content/ko/includes/task-tutorial-prereqs.md

from #18917
/language ko

@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 6, 2020
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Feb 6, 2020
@netlify
Copy link

netlify bot commented Feb 6, 2020

Deploy preview for k8s-dev-ko ready!

Built with commit e35c236

https://deploy-preview-19002--k8s-dev-ko.netlify.com

@claudiajkang
Copy link
Contributor

/assign @seokho-son

Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysyukr 님. 컨트리뷰션 감사합니다.
마이너한 리뷰 의견 남겼습니다. 참고하셔서 PR 업데이트 부탁드립니다.

@@ -9,7 +9,7 @@ card:

{{% capture overview %}}
쿠버네티스를 배포하면 클러스터를 얻는다.
{{< glossary_definition term_id="cluster" length="all" prepend="클러스터는">}}
{{< glossary_definition term_id="cluster" length="all" prepend="쿠버네티스 클러스터는 다음으로 구성된다">}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빌드된 화면을 보면 아래와 같이 나와서 적절한 조정이 필요해 보입니다.
쿠버네티스 클러스터는 다음으로 구성된다 컨테이너화된 애플리케이션을 실행하는 노드라고 하는 워커 머신의 집합.

쿠버네티스 클러스터는 다음으로 구성된다 [컨테이너화된 애플리케이션을 실행하는 노드라고 하는 워커 머신의 집합.]
[ ]부분이 cluster 용어의 한글 설명입니다.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분은 원문 수식어가 A cluster is 에서 A Kubernetes cluster consists of 로 변경되었기에 반영하면서 어색해진듯 합니다.

그리고 실제 반영되었을 때 클러스터 용어에 대한 디테일한 설명이 다 나오는 것으로 보아 쿠버네티스 클러스터는 으로만 변경하는게 조금 더 자연스러울 것 같습니다.

content/ko/docs/concepts/overview/components.md Outdated Show resolved Hide resolved
content/ko/includes/task-tutorial-prereqs.md Outdated Show resolved Hide resolved
@ysyukr
Copy link
Member Author

ysyukr commented Feb 14, 2020

@seokho-son 리뷰 감사합니다. 확인해서 업데이트했습니다 :)

@seokho-son
Copy link
Member

감사합니다^^
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit 67b96de into kubernetes:dev-1.17-ko.4 Feb 14, 2020
gochist pushed a commit that referenced this pull request Feb 15, 2020
* translate assign-pod-node.md (#18955)
* correct the misspelling (#19063)
* Update to Outdated files in dev-1.17-ko.4 branch. (#19002)

Co-Authored-By: KimMJ <[email protected]>
Co-Authored-By: forybm <[email protected]>
Co-Authored-By: Yuk, Yongsu <[email protected]>
k8s-ci-robot pushed a commit that referenced this pull request Feb 15, 2020
* translate assign-pod-node.md (#18955)
* correct the misspelling (#19063)
* Update to Outdated files in dev-1.17-ko.4 branch. (#19002)

Co-Authored-By: KimMJ <[email protected]>
Co-Authored-By: forybm <[email protected]>
Co-Authored-By: Yuk, Yongsu <[email protected]>

Co-authored-by: KimMJ <[email protected]>
Co-authored-by: forybm <[email protected]>
Co-authored-by: Yuk, Yongsu <[email protected]>
zacharysarah pushed a commit to zacharysarah/website that referenced this pull request Feb 15, 2020
* translate assign-pod-node.md (kubernetes#18955)
* correct the misspelling (kubernetes#19063)
* Update to Outdated files in dev-1.17-ko.4 branch. (kubernetes#19002)

Co-Authored-By: KimMJ <[email protected]>
Co-Authored-By: forybm <[email protected]>
Co-Authored-By: Yuk, Yongsu <[email protected]>

Co-authored-by: KimMJ <[email protected]>
Co-authored-by: forybm <[email protected]>
Co-authored-by: Yuk, Yongsu <[email protected]>
kbhawkey pushed a commit to kbhawkey/website that referenced this pull request Feb 18, 2020
* translate assign-pod-node.md (kubernetes#18955)
* correct the misspelling (kubernetes#19063)
* Update to Outdated files in dev-1.17-ko.4 branch. (kubernetes#19002)

Co-Authored-By: KimMJ <[email protected]>
Co-Authored-By: forybm <[email protected]>
Co-Authored-By: Yuk, Yongsu <[email protected]>

Co-authored-by: KimMJ <[email protected]>
Co-authored-by: forybm <[email protected]>
Co-authored-by: Yuk, Yongsu <[email protected]>
kbhawkey pushed a commit to kbhawkey/website that referenced this pull request Feb 19, 2020
* translate assign-pod-node.md (kubernetes#18955)
* correct the misspelling (kubernetes#19063)
* Update to Outdated files in dev-1.17-ko.4 branch. (kubernetes#19002)

Co-Authored-By: KimMJ <[email protected]>
Co-Authored-By: forybm <[email protected]>
Co-Authored-By: Yuk, Yongsu <[email protected]>

Co-authored-by: KimMJ <[email protected]>
Co-authored-by: forybm <[email protected]>
Co-authored-by: Yuk, Yongsu <[email protected]>
zacharysarah pushed a commit to zacharysarah/website that referenced this pull request Feb 21, 2020
* translate assign-pod-node.md (kubernetes#18955)
* correct the misspelling (kubernetes#19063)
* Update to Outdated files in dev-1.17-ko.4 branch. (kubernetes#19002)

Co-Authored-By: KimMJ <[email protected]>
Co-Authored-By: forybm <[email protected]>
Co-Authored-By: Yuk, Yongsu <[email protected]>

Co-authored-by: KimMJ <[email protected]>
Co-authored-by: forybm <[email protected]>
Co-authored-by: Yuk, Yongsu <[email protected]>
@ysyukr ysyukr deleted the outdated-ko.4 branch February 28, 2020 05:22
wawa0210 pushed a commit to wawa0210/website that referenced this pull request Mar 2, 2020
* translate assign-pod-node.md (kubernetes#18955)
* correct the misspelling (kubernetes#19063)
* Update to Outdated files in dev-1.17-ko.4 branch. (kubernetes#19002)

Co-Authored-By: KimMJ <[email protected]>
Co-Authored-By: forybm <[email protected]>
Co-Authored-By: Yuk, Yongsu <[email protected]>

Co-authored-by: KimMJ <[email protected]>
Co-authored-by: forybm <[email protected]>
Co-authored-by: Yuk, Yongsu <[email protected]>
VineethReddy02 pushed a commit to VineethReddy02/website that referenced this pull request Mar 22, 2020
* translate assign-pod-node.md (kubernetes#18955)
* correct the misspelling (kubernetes#19063)
* Update to Outdated files in dev-1.17-ko.4 branch. (kubernetes#19002)

Co-Authored-By: KimMJ <[email protected]>
Co-Authored-By: forybm <[email protected]>
Co-Authored-By: Yuk, Yongsu <[email protected]>

Co-authored-by: KimMJ <[email protected]>
Co-authored-by: forybm <[email protected]>
Co-authored-by: Yuk, Yongsu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants