Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old annotations from the kube-dns documentation. #6643

Closed
wants to merge 1 commit into from

Conversation

rohitagarwal003
Copy link
Member

@rohitagarwal003 rohitagarwal003 commented Dec 11, 2017

Removed in kubernetes/kubernetes#39284 and kubernetes/kubernetes#44137.

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 11, 2017
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Dec 11, 2017

Deploy preview ready!

Built with commit 87e2365

https://deploy-preview-6643--kubernetes-io-master-staging.netlify.com

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 11, 2017
@rohitagarwal003 rohitagarwal003 changed the title Fix HTML rendering. Remove old annotations from the kube-dns documentation. Dec 11, 2017
@rohitagarwal003
Copy link
Member Author

/assign @bowei
/unassign @a-mccarthy

@k8s-ci-robot k8s-ci-robot assigned bowei and unassigned a-mccarthy Dec 11, 2017

With v1.3, The Endpoints object can specify the `hostname` for any endpoint, along with its IP. The hostname field takes precedence over the hostname value
that might have been specified via the `endpoints.beta.kubernetes.io/hostnames-map` annotation.
With v1.3, The Endpoints object can specify the `hostname` for any endpoint, along with its IP. If the Endpoints are for a headless service, an A record is created with the format `<hostname>.<service name>.<pod namespace>.svc.<cluster domain>`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm the accuracy of this. I haven't tried doing this.

@rohitagarwal003
Copy link
Member Author

Nevermind, seems like #6479 already did this (and more) in a different branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants