Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document AllowedFlexVolumes in PSP #6967

Merged
merged 1 commit into from
Jan 22, 2018
Merged

Document AllowedFlexVolumes in PSP #6967

merged 1 commit into from
Jan 22, 2018

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Jan 15, 2018

Closes: #6447


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 15, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Jan 15, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit ed2dd9d

https://deploy-preview-6967--kubernetes-io-master-staging.netlify.com

@@ -28,6 +28,7 @@ administrator to control the following:
| Usage of host networking and ports | [`hostNetwork`, `hostPorts`](#host-namespaces) |
| Usage of volume types | [`volumes`](#volumes-and-file-systems) |
| Usage of the host filesystem | [`allowedHostPaths`](#volumes-and-file-systems) |
| Usage of FlexVolume drivers | [`allowedFlexVolumes](#flexvolume-drivers) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a backtick at the end of allowedFelxVolumes here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ... will fix.


**AllowedFlexVolumes** - Provides a whitelist of allowed FlexVolumes. Empty or
nil indicates that all FlexVolume drivers may be used. For example, the following
setting permits the `examle/fast_cache` driver to be used on nodes:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is "permits the" correct, or is "only permits the" more accurate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right.

@heckj heckj self-assigned this Jan 19, 2018
@tengqm
Copy link
Contributor Author

tengqm commented Jan 22, 2018

@heckj fixed.

@heckj
Copy link
Contributor

heckj commented Jan 22, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2018
@heckj heckj merged commit aef3969 into kubernetes:master Jan 22, 2018
@tengqm tengqm deleted the psp branch January 22, 2018 02:57
@php-coder
Copy link
Contributor

I have couple questions:

setting only permits the `examle/fast_cache` driver to be used on nodes:

```yaml
allowedFlexVolumes: [ "example/fast_cache" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this example incorrect and won't work :-|

allowedFlexVolumes accepts list of the objects (not list of the strings). See correct example in the original PR from @wanghaoran1988

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My fault. It should be a list of objects where each object has a driver property. Will fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants