Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes nesting overrides don't work with multiple defined resources #1251

Closed
mszostok opened this issue Sep 12, 2023 · 1 comment · Fixed by #1253
Closed

Kubernetes nesting overrides don't work with multiple defined resources #1251

mszostok opened this issue Sep 12, 2023 · 1 comment · Fixed by #1253
Assignees
Labels
bug Something isn't working
Milestone

Comments

@mszostok
Copy link
Contributor

Description

Botkube Kubernetes source doesn't respect nested overrides when multiple resources are provides, for example:

        namespaces:
          include:
            - ".*"
        event:
          types:
            - delete
            - error
        resources:
          - type: v1/configmaps
            namespaces:
              include:
                - ".*"
              exclude:
                - "gitlab-runner"
          - type: rbac.authorization.k8s.io/v1/roles
          - type: apps/v1/deployments

However, when you have only one resource, then it works as expected, for example:

        namespaces:
          include:
            - ".*"
        event:
          types:
            - delete
            - error
        resources:
          - type: v1/configmaps
            namespaces:
              include:
                - ".*"
              exclude:
                - "gitlab-runner"
@mszostok mszostok added the bug Something isn't working label Sep 12, 2023
@mszostok mszostok added this to the v1.5.0 milestone Sep 12, 2023
@mszostok mszostok self-assigned this Sep 12, 2023
@mszostok mszostok linked a pull request Sep 13, 2023 that will close this issue
@mszostok
Copy link
Contributor Author

Fix for this bug will be included in the patch release v1.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant