Helm upgrade with existingCommunicationsSecretName fails

[pkosiec]

Originally posted by @voriol in #1274 (comment)

---

When updating my helm chart to the latest version, 1.8.0 I got the following error:

Error: template: sre-botkube/charts/botkube/templates/persistent-config.yaml:6:23: executing "sre-botkube/charts/botkube/templates/persistent-config.yaml" at <index $secret.data "comm_config.yaml">: error calling index: index of untyped nil

Reviewing the latest changes I see that the line it refers to was changed in this commit

fdb389c#diff-e694b58be4de3f2b3d147e65317458bbbc0f5319bd07c703d80dc3b05bb5d1b7

Specifically, on line 6:

{{- $data := b64dec (index $secret.data "comm_config.yaml") -}}

This is the secret content:

apiVersion: v1
kind: Secret
metadata:
  name: botkube-communications
stringData:
  comm_config.yaml: |
    communications:
      default-group:
        ## Settings for Slack with Socket Mode.
        ...etc

I am doing something wrong?

Thanks

[pkosiec]

Hey @voriol,

There might be a bug in the Helm chart when using existing secret. Unfortunately we're focused on different priorities and I think we won't be able to fix this issue in next few weeks. Here are the possible solutions/workarounds I can see:

1. You might try migrating your instance to Botkube Cloud, which doesn't have this issue as it doesn't use the complex ConfigMap merging logic. It's free for a single cluster!
2. Alternatively, you could switch to use built-in secret with platform details
3. Or, if you have a bit of time and energy, you could contribute and investigate/fix the bug. That would be much appreciated 🙏 Here are a few tips:

You can clone the repo and try to modify the Helm chart in this place:
https://github.com/kubeshop/botkube/blob/main/helm/botkube/templates/persistent-config.yaml#L6

I didn't try it yet, but this could work:

 {{- if .Values.existingCommunicationsSecretName }}
   {{- $secret := lookup "v1" "Secret" .Release.Namespace .Values.existingCommunicationsSecretName | default dict  }}
-  {{- $data := b64dec (index $secret.data "comm_config.yaml") -}}
+  {{- $secretData := $secret.data | default dict -}}
+  {{- $data := b64dec (index $secretData "comm_config.yaml" | default "") -}}
   {{- $dataYaml := $data | fromYaml -}}
   {{- $communications =  $dataYaml.communications }}
 {{- end }}

Hope that helps. Cheers!

[voriol]

I'll try to take a look at it next week.

thanks @pkosiec

[pkosiec]

Perfect, thank you!

[voriol]

Hi @pkosiec, your solutions works fine!

 {{- if .Values.existingCommunicationsSecretName }}
   {{- $secret := lookup "v1" "Secret" .Release.Namespace .Values.existingCommunicationsSecretName | default dict  }}
-  {{- $data := b64dec (index $secret.data "comm_config.yaml") -}}
+  {{- $secretData := $secret.data | default dict -}}
+  {{- $data := b64dec (index $secretData "comm_config.yaml" | default "") -}}
   {{- $dataYaml := $data | fromYaml -}}
   {{- $communications =  $dataYaml.communications }}
 {{- end }}

I open the PR #1378

Thanks