Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make event notifications actionable #786

Closed
9 tasks done
lpetkov opened this issue Oct 3, 2022 · 3 comments · Fixed by #822
Closed
9 tasks done

Make event notifications actionable #786

lpetkov opened this issue Oct 3, 2022 · 3 comments · Fixed by #822
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@lpetkov
Copy link

lpetkov commented Oct 3, 2022

Add a drop down to each Botkube notification message with a list of relevant actions that:

  • are supported by Botkube
  • are applicable to the resource type
  • the bot has permissions to actually run
  • Always return enabled verbs for a given channel regardless the resource (this is what @mszostok already did)
    • Simplified implementation, you can hardcode some verbs for specific resources
    • Populate resources dynamically and attach describe if they have get
    • logs should be handled only for Pods
    • Usekubectl api-resources -owide for verbs (use client-go) if that's good idea
    • Create it as a generic package - sync up with Interactive kubectl (Slack) #748 owner, as it will be used there as well
    • Can be worked on in parallel
  • Documentation
  • Basic telemetry: add eventDropdown origin for the executed command
  • Integration testing out of scope (as we use legacy Slack)

Update

Example:

image

This will make each notification (or most notifications) actionable and therefore will make the bot easier to use.

Out of scope

Stretch
If kubectl is not enabled, whenever we have the technical ability to do so, add a button to enable kubectl under each notification:

image

@lpetkov lpetkov added the enhancement New feature or request label Oct 3, 2022
@mszostok mszostok added this to the v0.14.0 milestone Oct 3, 2022
@mszostok mszostok removed their assignment Oct 4, 2022
@pkosiec pkosiec modified the milestones: v0.14.0, v0.15.0 Oct 4, 2022
@pkosiec pkosiec removed the needs-triage Relates to issues that should be refined label Oct 4, 2022
@pkosiec pkosiec self-assigned this Oct 4, 2022
@mszostok
Copy link
Contributor

mszostok commented Oct 5, 2022

Filtering should not be via dropdown but inlined:
image

Edit(@pkosiec): Out of scope as we agreed to simplify the usual flow to run the command instantly.

@pkosiec
Copy link
Member

pkosiec commented Oct 18, 2022

Update: I will hide the "Delete" option for actionable notifications for now. This doesn't impact the "Actionable messages" feature at all.

I discussed the edge case with @lpetkov (which happens when user explicitly enables the "delete" verb for given K8s resource). Unfortunately I ran out of time - sounds like a rare edge case not worth to invest in right now, as we have different priorities related to Kubecon.

I will create a follow-up task for that and we can see if people really want to delete K8s resources from notifications 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants