-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make event notifications actionable #786
Comments
Additional scope: |
Filtering should not be via dropdown but inlined: Edit(@pkosiec): Out of scope as we agreed to simplify the usual flow to run the command instantly. |
Update: I will hide the "Delete" option for actionable notifications for now. This doesn't impact the "Actionable messages" feature at all. I discussed the edge case with @lpetkov (which happens when user explicitly enables the "delete" verb for given K8s resource). Unfortunately I ran out of time - sounds like a rare edge case not worth to invest in right now, as we have different priorities related to Kubecon. I will create a follow-up task for that and we can see if people really want to delete K8s resources from notifications 🙂 |
Add a drop down to each Botkube notification message with a list of relevant actions that:
get
logs
should be handled only for Podskubectl api-resources -owide
for verbs (use client-go) if that's good ideaeventDropdown
origin for the executed commandUpdate
Support filtering from the flow 2 - https://www.figma.com/proto/UcaGQ1UiBziOQbNPmSwE0T/grep?page-id=0%3A1&node-id=56%3A443&viewport=163%2C220%2C0.08&scaling=scale-down&starting-point-node-id=56%3A443&show-proto-sidebar=1 - reuse the same modal from Interactivity for output filtering #788- dropped from the scopeAdd delete confirmation - will be followed-up in Enable resource deletion from actionable notifications with extra confirmation #824; for now we'll hide the option
I'll work on a follow-up PR with a special case for delete. Any kind of minimal extra confirmation works:
If that'll be too big effort - filter the "delete" option ouf of this dropdown.
Example:
This will make each notification (or most notifications) actionable and therefore will make the bot easier to use.
Out of scope
Stretch
If
kubectl
is not enabled, whenever we have the technical ability to do so, add a button to enable kubectl under each notification:The text was updated successfully, but these errors were encountered: