Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trigger grpc status does not match tracetest.response.status in "Tracetest trigger" span #2712

Closed
jorgeepc opened this issue Jun 12, 2023 · 0 comments · Fixed by #2741
Closed
Assignees
Labels
bug Something isn't working triage requires triage

Comments

@jorgeepc
Copy link
Contributor

Describe the bug
The testRun field triggerResult.grpc does not include the grcp status code and the webApp is defaulting it to 200. This 200 value does not match with the tracetest.response.status attribute in the Tracetest trigger span. The error is visible now because we added the ability to create a TestSpec from the TriggerResponse data. If you try to create a TestSpec from the ResponseData - Status field for a GRPC trigger you will see the mismatch.

To Reproduce
Steps to reproduce the behavior:

  1. Go to a grpc test run, trigger tab.
  2. Hover on the Status field and select Create test spec
  3. Save the spec and validate the result

Expected behavior
The triggerResult.grpc.code field should match the value from the tracetest.response.status attribute in the Tracetest trigger span.

Screenshots

Screenshot 2023-06-12 at 12 53 50 Screenshot 2023-06-12 at 12 54 10
@jorgeepc jorgeepc added bug Something isn't working triage requires triage labels Jun 12, 2023
@xoscar xoscar self-assigned this Jun 15, 2023
@xoscar xoscar linked a pull request Jun 15, 2023 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage requires triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants