Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add api group to clusterrole's first rule in config/manager #47

Closed
semmet95 opened this issue May 6, 2023 · 2 comments · Fixed by #48
Closed

Add api group to clusterrole's first rule in config/manager #47

semmet95 opened this issue May 6, 2023 · 2 comments · Fixed by #48

Comments

@semmet95
Copy link
Contributor

semmet95 commented May 6, 2023

Describe the bug
Getting the error

The ClusterRole "kube-trigger-manager-role" is invalid: rules[0].apiGroups: Required value: resource rules must supply at least one api group

when applying config/manager/role.yaml file.

To Reproduce
Steps to reproduce the behavior:

  1. Follow the Quick Start guide.
  2. Apply all the files in config/crd, config/definition, and config/manager respectively.
  3. kubectl apply -f will throw the error when trying to apply role.yaml.

Expected behavior
Successful creation of ClusterRole kube-trigger-manager-role

Kube Trigger Version

  • kube-trigger version: 1.0.0 (kube-trigger addon)

Cluster information

  • Minikube version: v1.30.1
  • Kuberentes version: v1.24.13
  • Kubevela version: v1.8.1

Additional context
I enabled the kube-trigger addon after installing kubevela .

@semmet95
Copy link
Contributor Author

semmet95 commented May 6, 2023

I have already updated the ClusterRole and tested the changes, along with some minor updates to the Quick Start instructions. The changes are ready for a PR.

@FogDong
Copy link
Member

FogDong commented May 9, 2023

Hi @semmet95
Welcome to contribute and create a PR for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants