Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move build to sbt-github-actions #296

Closed
kubukoz opened this issue Apr 3, 2021 · 4 comments
Closed

Move build to sbt-github-actions #296

kubukoz opened this issue Apr 3, 2021 · 4 comments

Comments

@kubukoz
Copy link
Owner

kubukoz commented Apr 3, 2021

Travis CI has had its time, but I've had a better experience with GitHub Actions and Daniel's generative sbt plugin. We should migrate the build to use that instead.

The obvious issue with the migration that I can foresee is the microsite, which might require some extra dependencies like sass & jekyll. It's probably a good idea to start without the site and then we'll add it once we have the Actions working.

Some inspiration:

@kubukoz kubukoz mentioned this issue Apr 3, 2021
@kubukoz
Copy link
Owner Author

kubukoz commented Apr 3, 2021

Some extra notes if you want to work on it @amsayk:

We'll need to add secrets to the repo, but that can be done after everything is set up in the code. Probably the best starting point is to copy-paste the changes from kubukoz/slick-effect@149ea9c .

In general, this will require some changes to the build e.g. moving crossScalaVersions to ThisBuild/ instead of the individual projects. We also need to make sure we're cross-compiling everything to the same set of Scala versions, as that's the only thing that works. Again, this might be a problem for the microsite, we'll see. Maybe the site can be built in a separate job or something, for starters let's skip the site completely.

@therealcisse
Copy link
Contributor

therealcisse commented Apr 4, 2021

Hi @kubukoz, I'll take work on this. Thanks for the tips.

@therealcisse
Copy link
Contributor

I will work on the site on a separate pull request.

@kubukoz
Copy link
Owner Author

kubukoz commented Apr 10, 2021

Closed in #299. Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants