New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typing): don't mark BabelConfig as internal type #1667

Merged

ahnpnl merged 1 commit into kulshekhar:master from ahnpnl:expose-babel-config-type

May 21, 2020

Collaborator

ahnpnl commented May 21, 2020 •

edited

Loading

Summary

Close #1666

Test plan

Test against the repo in #1666

Does this PR introduce a breaking change?

Yes
No

Other information

Also lock typescript at 3.x in package.json


          fix(typing): don't mark BabelConfig as internal type

34ced98

ahnpnl requested a review from kulshekhar as a code owner

May 21, 2020 08:57

coveralls commented May 21, 2020

Pull Request Test Coverage Report for Build 4899

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.826%

Totals
Change from base Build 4898:	0.0%
Covered Lines:	1060
Relevant Lines:	1095

💛 - Coveralls

kulshekhar approved these changes

View reviewed changes

ahnpnl merged commit 558c307 into kulshekhar:master

ahnpnl deleted the expose-babel-config-type branch

May 21, 2020 09:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet