Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): generate source map correctly when tsconfig mapRoot is set #1741

Merged
merged 1 commit into from
Jun 20, 2020
Merged

fix(compiler): generate source map correctly when tsconfig mapRoot is set #1741

merged 1 commit into from
Jun 20, 2020

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Jun 20, 2020

Summary

Fixes #1718

Test plan

Added e2e test

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@ahnpnl ahnpnl requested a review from kulshekhar as a code owner June 20, 2020 11:42
@ahnpnl ahnpnl changed the title fix(compiler): generate source map also considering tsconfig mapRoots fix(compiler): generate source map also considering tsconfig mapRoot Jun 20, 2020
@ahnpnl ahnpnl changed the title fix(compiler): generate source map also considering tsconfig mapRoot fix(compiler): generate source map correctly when tsconfig mapRoot is set Jun 20, 2020
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5151

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 92.873%
Totals Coverage Status
Change from base Build 5150: 0.03%
Covered Lines: 1059
Relevant Lines: 1094
💛 - Coveralls

@ahnpnl ahnpnl merged commit 01ac417 into kulshekhar:master Jun 20, 2020
@ahnpnl ahnpnl deleted the fix-source-map branch June 20, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulshekhar kulshekhar kulshekhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeScript mapRoot setting breaks source map URL generation
3 participants
@ahnpnl @coveralls @kulshekhar