fix: move @types/jest to dependencies to work well with yarn 2 #1859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5577
💛 - Coveralls |
kulshekhar
previously approved these changes
Aug 6, 2020
kulshekhar
approved these changes
Aug 6, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Because we export
mocked, a util function, as a public function but we also refer to@types/jesthere which isn’t complied with yarn 2This PR moves
@types/jestto dependencies list.Fixes #1857
Test plan
Pack a tgz file and install with yarn 2 to the project in #1857
Does this PR introduce a breaking change?
Other information
N.A.