Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): allow to override readTsConfig #2063

Merged
merged 2 commits into from
Oct 26, 2020
Merged

feat(config): allow to override readTsConfig #2063

merged 2 commits into from
Oct 26, 2020

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Oct 24, 2020

Summary

  • Allow to override readTsConfig
  • Expose _transformCfgStr, _configSet, _overriddenCompilerOptions

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@coveralls
Copy link

coveralls commented Oct 25, 2020

Pull Request Test Coverage Report for Build 6320

  • 15 of 15 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 93.661%

Totals Coverage Status
Change from base Build 6319: 0.003%
Covered Lines: 1020
Relevant Lines: 1049

💛 - Coveralls

@ahnpnl ahnpnl marked this pull request as draft October 25, 2020 18:55
@ahnpnl ahnpnl marked this pull request as ready for review October 25, 2020 23:13
kulshekhar
kulshekhar previously approved these changes Oct 26, 2020
- Change `_readTsConfig` to `_resolveTsConfig`
- Allow to override `_resolveTsConfig` via overload signature
- Expose `_transformCfgStr`, `_configSet`, `_overriddenCompilerOptions`
@ahnpnl ahnpnl changed the title refactor(config): allow to override readTsConfig feat(config): allow to override readTsConfig Oct 26, 2020
@ahnpnl ahnpnl merged commit 9f46ace into kulshekhar:master Oct 26, 2020
@ahnpnl ahnpnl deleted the typings branch October 26, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants