Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module declaration from 3rd party modules does not work in 26.4.2 #2068

Closed
L2jLiga opened this issue Oct 26, 2020 · 3 comments · Fixed by #2062
Closed

Module declaration from 3rd party modules does not work in 26.4.2 #2068

L2jLiga opened this issue Oct 26, 2020 · 3 comments · Fixed by #2062

Comments

@L2jLiga
Copy link

L2jLiga commented Oct 26, 2020

💥 Regression Report

Dependabot updated an dependency to 26.4.2 and it breaks tests
I have an fastify application with fastify-oas on board (which declares fastify module and adds new properties to it

Link: https://github.com/L2jLiga/fastify-decorators/blob/b27d40146de5c04a1ca882dffd74845e4b49ebb3/examples/swagger/src/schemas.ts#L2

Last working version

Worked up to version: 26.4.1

Stopped working in version: 26.4.2

To Reproduce

Steps to reproduce the behavior:

  1. create package
  2. install fastify, fastify-oas and typescript
  3. import RouteSchema from fastify (declaration in fastify-oas)
  4. create jest test which will just import this file
  5. see error

Expected behavior

Tests are passing

Link to repo (highly encouraged)

https://github.com/L2jLiga/fastify-decorators/tree/b27d40146de5c04a1ca882dffd74845e4b49ebb3/examples/swagger

Debug log:

# content of ts-jest.log :

ts-jest.log

envinfo

System:
    OS: Windows 10 20H2 / Ubuntu 20.04

Npm packages:
    jest: 26.6.0 / 26.6.1 (latest)
    ts-jest: 26.4.2
    typescript: 4.0.3
    babel(optional): n/a
@ahnpnl
Copy link
Collaborator

ahnpnl commented Oct 26, 2020

fixed in #2062

@ahnpnl ahnpnl closed this as completed Oct 26, 2020
@L2jLiga
Copy link
Author

L2jLiga commented Oct 26, 2020

Ok, thanks! Any timeline to release?

@ahnpnl
Copy link
Collaborator

ahnpnl commented Oct 26, 2020

certainly this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants