Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select babel version with option #684

Closed
Ailrun opened this issue Aug 21, 2018 · 8 comments
Closed

Select babel version with option #684

Ailrun opened this issue Aug 21, 2018 · 8 comments
Milestone

Comments

@Ailrun
Copy link

Ailrun commented Aug 21, 2018

Issue :

ts-jest detect @babel/core automatically before detecting babel-core, so if I use some package that uses @babel/core internally, I cannot use babel-core.

Expected behavior :

I can use babel-core if I want.

Output from debug log :

# content of debug.txt :

Minimal repo :

@huafu
Copy link
Collaborator

huafu commented Sep 1, 2018

@Ailrun you can test our latest beta (see #697) which will use the babel-core first and then @babel/core. Then you install or not the [email protected] to use the 7 or not, just as other babel related packages.

@Ailrun
Copy link
Author

Ailrun commented Sep 12, 2018

@huafu I tested with both versions, and both work well. Thanks.

@Ailrun
Copy link
Author

Ailrun commented Sep 12, 2018

However, coverage does not work with babel@7... I will make another issue for this.

@huafu
Copy link
Collaborator

huafu commented Sep 12, 2018

@Ailrun you meant, with ts-jest beta + babel7, coverage do not work?

@Ailrun
Copy link
Author

Ailrun commented Sep 12, 2018

In ts-jest@next, @babel/core@7, and babel-jest@23.6. I'm trying to reproduce it with minimal repo.

@huafu
Copy link
Collaborator

huafu commented Sep 12, 2018

Thanks a lot @Ailrun. I'm actually adding an e2e test in beta for coverages, just realized there was none!

BTW, we now have a Slack channel

@Ailrun
Copy link
Author

Ailrun commented Sep 13, 2018

I think I also could close this.

@Ailrun Ailrun closed this as completed Sep 13, 2018
@huafu
Copy link
Collaborator

huafu commented Sep 13, 2018

@Ailrun we left this one open as the current release does not fix the issue, only beta ;-)

Update: when beta will be merged to master and published on the latest and not next npm tag, then we'll close this issue. Other issues, prefixed with [beta], are only related to beta and can be closed as soon as a new beta is released

@huafu huafu reopened this Sep 13, 2018
@huafu huafu added this to the v23.10.0 milestone Sep 19, 2018
@huafu huafu closed this as completed Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants