Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verbatimModuleSyntax support #4082

Closed
wants to merge 2 commits into from
Closed

verbatimModuleSyntax support #4082

wants to merge 2 commits into from

Conversation

simPod
Copy link

@simPod simPod commented Apr 3, 2023

@simPod simPod mentioned this pull request Apr 3, 2023
Closed
test: fix config
955d126 
`verbatimModuleSyntax: true` only works when running with Jest in ESM mode. In the example of `ts-only`, `tsconfig-esm.json` is the config which is used by `test-esm` script. This script uses `jest-esm.config.js`
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4596161322

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 95.991%
Totals Coverage Status
Change from base Build 4595719534: 0.2%
Covered Lines: 4055
Relevant Lines: 4154
💛 - Coveralls

@simPod simPod closed this Apr 3, 2023
@simPod simPod deleted the repro branch April 3, 2023 14:53
@alecmev
Copy link

alecmev commented Apr 5, 2023

@simPod Please, reopen this. The missing ingredient is "isolatedModules": true in tsconfig-esm.json.

@ahnpnl I'm able to reproduce this. There is no error, Jest just "hangs".

@simPod
Copy link
Author

simPod commented Apr 5, 2023

Isolated modules true should not be set when verbatimModuleSyntax is set (e. g. vercel/next.js#46509).

Or ideally open similar PR with example of what you mean?

@alecmev
Copy link

alecmev commented Apr 7, 2023

Thanks, you're right! Surprisingly, tsc worked fine, so I assumed it was ts-jest's fault somehow. Simply getting rid of "isolatedModules": true was enough.

@evantill evantill mentioned this pull request Apr 9, 2023
Closed
@claremacrae claremacrae mentioned this pull request Jul 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulshekhar kulshekhar Awaiting requested review from kulshekhar kulshekhar will be requested when the pull request is marked ready for review kulshekhar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simPod @coveralls @alecmev @ahnpnl