Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package grafana dashboards inside the plugin #33

Open
lahabana opened this issue Dec 8, 2021 · 14 comments
Open

Package grafana dashboards inside the plugin #33

lahabana opened this issue Dec 8, 2021 · 14 comments
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lahabana
Copy link
Contributor

lahabana commented Dec 8, 2021

Description

We now have a plugin that's versioned and distributed.

It would be good to have the dashboards from: https://github.com/kumahq/kuma/tree/master/app/kumactl/data/install/k8s/metrics/grafana packaged in the plugin instead.
Once this is done we can version these separately from the Kuma and only publish updates when needed.
@lahabana lahabana added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Dec 8, 2021
@lahabana
Copy link
Contributor Author

lahabana commented Dec 8, 2021

As part of this import we'll need to rewrite dashboards in an updated version

@lahabana lahabana mentioned this issue Dec 8, 2021
Closed
@lahabana lahabana added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Dec 13, 2021
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jan 13, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Jan 13, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Feb 13, 2022
@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Mar 17, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Apr 17, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Apr 25, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label May 26, 2022
@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label May 27, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jun 27, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Jun 27, 2022
@michaelbeaumont michaelbeaumont self-assigned this Jul 6, 2022
@michaelbeaumont
Copy link
Contributor

michaelbeaumont commented Aug 9, 2022 •
edited
Loading

@lahabana as far as the grafana.com dashboards, the dashboard JSON used to publish to grafana.com is different from the JSON that ends up configured in Grafana, so we have to manually export them by going to the dashboard > Share > Export and select Export for sharing externally.

https://grafana.com/docs/grafana/latest/dashboards/export-import/

@lahabana
Copy link
Contributor Author

That's depressing :)

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Nov 21, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Nov 21, 2022
@mmorel-35
Copy link
Contributor

Have you seen this ? That's the way grafana is providing dashboards for its built-in plugin maybe it worth trying the same approach here ?

@lahabana
Copy link
Contributor Author

Could be interesting indeed thanks for the tip!

@michaelbeaumont michaelbeaumont removed their assignment Feb 9, 2023
@michaelbeaumont michaelbeaumont added triage/pending This issue will be looked at on the next triage meeting and removed triage/accepted The issue was reviewed and is complete enough to start working on it labels Feb 22, 2023
@jakubdyszkiewicz
Copy link
Contributor

Triage: as a final step, don't forget to put into docs link to a JSON that you can install in Grafana

@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Feb 27, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label May 29, 2023
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@slonka slonka removed the triage/stale Inactive for some time. It will be triaged again label May 30, 2023
@lahabana lahabana mentioned this issue Jul 24, 2023
Closed
6 tasks
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Aug 29, 2023
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@lahabana @michaelbeaumont @slonka @jakubdyszkiewicz @mmorel-35