Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ks.get_key(None) returns the 1st key #146

Closed
euri10 opened this issue Nov 8, 2023 · 1 comment · Fixed by #147
Closed

ks.get_key(None) returns the 1st key #146

euri10 opened this issue Nov 8, 2023 · 1 comment · Fixed by #147

Comments

@euri10
Copy link
Contributor

euri10 commented Nov 8, 2023

which given the way _internal_get_key is logical (this is the else case and the sql query fetches all keys) but does that make sense from a user perspective ?
I was surprised to see this behaviour and would have expected a KeyNotFoundError instead.

Current implementation of _internal_get_key also has a allkeys parameters but it is not used.

I wrote a little PR that uses that parameter and raise a KeyNotFoundError if get_key gets passed a None

@kushaldas
Copy link
Owner

Bug introduced by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants