You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
which given the way _internal_get_key is logical (this is the else case and the sql query fetches all keys) but does that make sense from a user perspective ?
I was surprised to see this behaviour and would have expected a KeyNotFoundError instead.
Current implementation of _internal_get_key also has a allkeys parameters but it is not used.
I wrote a little PR that uses that parameter and raise a KeyNotFoundError if get_key gets passed a None
The text was updated successfully, but these errors were encountered:
which given the way
_internal_get_key
is logical (this is the else case and the sql query fetches all keys) but does that make sense from a user perspective ?I was surprised to see this behaviour and would have expected a KeyNotFoundError instead.
Current implementation of _internal_get_key also has a allkeys parameters but it is not used.
I wrote a little PR that uses that parameter and raise a KeyNotFoundError if get_key gets passed a None
The text was updated successfully, but these errors were encountered: