Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for tagless components? #3

Closed
FezVrasta opened this issue Apr 24, 2017 · 4 comments
Closed

Support for tagless components? #3

FezVrasta opened this issue Apr 24, 2017 · 4 comments

Comments

@FezVrasta
Copy link

I think it would be a nice addition to support tagless components:

export default Ember.Component.extend({
  tagName: '',
});
@kybishop
Copy link
Owner

kybishop commented May 2, 2017

This must have been added right before I clicked the "Watch" button for the repo, sorry for the late response!

@FezVrasta do you mean targeting a tagless component, passing a tagless component into an {{#ember-popper}}, or something else?

@kybishop
Copy link
Owner

@FezVrasta just wanted to send a ping to hear your thoughts

@FezVrasta
Copy link
Author

Sorry, I simply forwarded a request I got on my repository. I don't use Ember so I can't be much of a help...

@kybishop
Copy link
Owner

heh no worries.

I think our hands are a bit tied with targeting tagless components, since popper.js needs an element to target.

One can currently pass in a tagless component as the popper's content, though it will be automatically wrapped to give popper.js something to target.

Going to close this out for now, though happy to hear specific requests from people if there is a pattern they'd like to see enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants