You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#80 dropped support for node 4, at least it declared so in its package.json. While EOL is just in a few days, any addons building on top of ember-popper that follow SemVer and have reached a stable version (>1.0) would have to do a major version bump to drop support for it, which is not always desirable.
Is there any good reason for requiring node 6? At first sight, I don't see any code in node-land requiring node 6 features, not here and also not in ember-decorators, which as of 2.0 also requires 6+. So a fix could be as simple as updating engines (and probably travis.yml).
Given that Node v4 is about to be EOL'd, I don't think it's worth the effort to continue supporting it. I forget the exact reasons for why we dropped support in ember-decorators, but it wasn't just out of convenience. Most libraries should major rev anyways as we move forward, numbers are cheap 😄
#80 dropped support for node 4, at least it declared so in its
package.json
. While EOL is just in a few days, any addons building on top of ember-popper that follow SemVer and have reached a stable version (>1.0) would have to do a major version bump to drop support for it, which is not always desirable.This currently at least breaks installation of this addon and any other having it as a dependency under node 4 (without the
--ignore-engines
flag), e.g here: https://travis-ci.org/simplabs/ember-validated-form-buffer/builds/370595623#L531Is there any good reason for requiring node 6? At first sight, I don't see any code in node-land requiring node 6 features, not here and also not in
ember-decorators
, which as of 2.0 also requires 6+. So a fix could be as simple as updatingengines
(and probablytravis.yml
)./cc @pzuraq @Turbo87
The text was updated successfully, but these errors were encountered: