Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 4 support #84

Closed
simonihmig opened this issue Apr 24, 2018 · 1 comment
Closed

Node 4 support #84

simonihmig opened this issue Apr 24, 2018 · 1 comment

Comments

@simonihmig
Copy link
Collaborator

#80 dropped support for node 4, at least it declared so in its package.json. While EOL is just in a few days, any addons building on top of ember-popper that follow SemVer and have reached a stable version (>1.0) would have to do a major version bump to drop support for it, which is not always desirable.

This currently at least breaks installation of this addon and any other having it as a dependency under node 4 (without the --ignore-engines flag), e.g here: https://travis-ci.org/simplabs/ember-validated-form-buffer/builds/370595623#L531

Is there any good reason for requiring node 6? At first sight, I don't see any code in node-land requiring node 6 features, not here and also not in ember-decorators, which as of 2.0 also requires 6+. So a fix could be as simple as updating engines (and probably travis.yml).

/cc @pzuraq @Turbo87

@pzuraq
Copy link
Collaborator

pzuraq commented Apr 24, 2018

Given that Node v4 is about to be EOL'd, I don't think it's worth the effort to continue supporting it. I forget the exact reasons for why we dropped support in ember-decorators, but it wasn't just out of convenience. Most libraries should major rev anyways as we move forward, numbers are cheap 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants