Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning on Ember 3.4 from use of sendAction #91

Closed
ghost opened this issue Aug 30, 2018 · 2 comments
Closed

Deprecation warning on Ember 3.4 from use of sendAction #91

ghost opened this issue Aug 30, 2018 · 2 comments

Comments

@ghost
Copy link

ghost commented Aug 30, 2018

This line in ember-popper-base.js triggers deprecation warnings in Ember 3.4.

this.sendAction('registerAPI', this._getPublicAPI());

Can we change it to this.registerAPI(this._getPublicAPI()), given that closure actions are the way now and sendAction is deprecated?

I note the eslint-disable ember/closure-actions currently applied, not sure if there was a rationale for this though.

@kybishop
Copy link
Owner

kybishop commented Sep 4, 2018

This was a holdover from 1.11 support, but I'm comfortable dropping that support now. Will come up with a PR to do so, or accept #92 if we can get the tests green ;)

@kybishop
Copy link
Owner

closed in #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant