Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mass insertion logging #24

Open
kyleaoman opened this issue Jun 30, 2023 · 0 comments
Open

Improve mass insertion logging #24

kyleaoman opened this issue Jun 30, 2023 · 0 comments

Comments

@kyleaoman
Copy link
Owner

Currently the total mass in the source is recorded in the log, and then the fraction of that mass that is inserted in the cube. This often leads to low fractions simply because much of the mass is outside of the datacube aperture. Should additionally record the mass in the source after it is pruned to the desired aperture, and also log fractions of this mass. It's useful to flag for the user both (i) when much of their source is outside of the aperture (which they might not have expected), and (ii) when significant amounts of mass that are in aperture don't end up in the cube (probably indicating that something has gone wrong in the approximations used in the SPH kernels or similar).

@kyleaoman kyleaoman added this to the v2.1 milestone Jun 30, 2023
@kyleaoman kyleaoman self-assigned this Jul 18, 2023
@kyleaoman kyleaoman modified the milestones: v2.1, v2.2 Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant