Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source, DataCube objects can be in unusable state #47

Open
kyleaoman opened this issue Mar 19, 2024 · 0 comments
Open

Source, DataCube objects can be in unusable state #47

kyleaoman opened this issue Mar 19, 2024 · 0 comments
Assignees
Labels
Milestone

Comments

@kyleaoman
Copy link
Owner

The pruning mechanism of source modules and the padding mechanism of datacubes mean that they can be put into a state where they should not be passed to martini. For example, once a mock is made with a source (it has been pruned in the process), applying a rotation and trying to produce a second mock of the same source should be invalid because it has lost its particles. Either the object should be flagged as no longer valid and martini modified to reject the source, or pruned particles should be kept aside (or masked) within the object and restored after use. Some treatment of padding of datacubes along the same lines would also be a good idea.

@kyleaoman kyleaoman added the bug label Mar 19, 2024
@kyleaoman kyleaoman added this to the v2.1 milestone Mar 19, 2024
@kyleaoman kyleaoman self-assigned this Mar 19, 2024
@kyleaoman kyleaoman modified the milestones: v2.1, v2.2 Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant