Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GopherCon work on govendor importer #2

Open
5 of 8 tasks
kyleconroy opened this issue Jul 15, 2017 · 6 comments
Open
5 of 8 tasks

GopherCon work on govendor importer #2

kyleconroy opened this issue Jul 15, 2017 · 6 comments

Comments

@kyleconroy
Copy link
Owner

kyleconroy commented Jul 15, 2017

TODO:

  • Figure out what the tree option does
  • Generate a Gopkg.lock file
  • Contemplate Version in the constraints (@kyleconroy)
  • Add vendor.json files to testdata for unit test
  • Write unit tests
  • Write integration tests (@brendan-munro)
  • Add support for rootPath top level property
  • Add support for ignores top level property

PR:
golang#815

@rfay rfay changed the title GopherCon work GopherCon work on govendor importer Jul 15, 2017
@rfay
Copy link

rfay commented Jul 15, 2017

@joeygoode
Copy link
Collaborator

It seems like we don't need to muck with rootPath. Govendor only appears to write to the field and never use it.

$ git grep RootPath
context/vendorFile.go:  ctx.VendorFile.RootPath = ctx.RootImportPath
doc/implementation.md: - [x] Add RootPath (rootPath) to vendor.json file.
vendorfile/file.go:     RootPath string // Import path of vendor folder
vendorfile/file.go:     setField(&vf.RootPath, vf.all, rootPathNames)
vendorfile/file.go:     setObject(vf.RootPath, vf.all, rootPathNames, true)

@kyleconroy
Copy link
Owner Author

After talking to the maintainers, we're going to set the manifest constraint to gps.Any() and the lockfile constraint to the revision.

@joeygoode
Copy link
Collaborator

Looks like we're ignoring "origin" when a version isn't set. We should properly set this in the manifest, even when there is only a revision hash.

@brendan-munro
Copy link
Collaborator

I'm working through converting the edge cases available into integration test cases. One has been merged in to allow a bug to be tested (and fixed), the rest will get merged in when complete.

@otoolec
Copy link
Collaborator

otoolec commented Jul 15, 2017

Adding some unit tests and will look into how we can fix that 'origin' issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants