Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add documentation and examples for sqlc.narg #1579

Closed
wants to merge 11 commits into from

Conversation

skabbes
Copy link
Contributor

@skabbes skabbes commented Apr 30, 2022

To complete the sqlc.narg feature defined here: #1536

Feel free to edit / make your own my tone / wording.

@skabbes
Copy link
Contributor Author

skabbes commented May 1, 2022

@kyleconroy can you pay special attention to this:
b9efe90

I am not sure if it was the right thing to do, but it seemed completely unused (or at least unneeded)

Could you also review the recommitting of the python and kotlin examples. I tried to fix a kotlin issue, but I have no idea what the correct kotlin should be. Maybe @mightyguava is around to advise?

@skabbes
Copy link
Contributor Author

skabbes commented May 1, 2022

Given the build issues I am having, I isolated the documentation only (no examples) here

Copy link
Collaborator

@kyleconroy kyleconroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also don't know Kotlin super well. Will take me quite a bit to review this one.

@skabbes
Copy link
Contributor Author

skabbes commented May 1, 2022

I think we can likely just close this then. Anyone trying to use sqlc.narg (or sqlc.arg for that matter) + kotlin will have issues, but at that point we'll have a Kotlin expert to weigh in and advise.

@skabbes skabbes closed this May 1, 2022
@skabbes skabbes deleted the narg_docs branch May 1, 2022 17:38
@mightyguava
Copy link
Contributor

Sorry, I didn’t quite end up getting adoption this on my side either. 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants