Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to easily manage unmanaged module #3357

Closed
pPrecel opened this issue Sep 23, 2024 · 3 comments · Fixed by #3427
Closed

Add possibility to easily manage unmanaged module #3357

pPrecel opened this issue Sep 23, 2024 · 3 comments · Fixed by #3427
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@pPrecel
Copy link
Contributor

pPrecel commented Sep 23, 2024

Description

Now if a module is configured as unmanaged on the Kyma CR level, it's not possible to turn it managed without editing raw yaml.
The following screenshot shows an unmanaged serverless module:

Screenshot 2024-09-23 at 13 44 52

The Edit view should have checkbox for every module to easily enable/disable management of every module. Now it looks like this:

Screenshot 2024-09-23 at 13 46 07
@mrCherry97 mrCherry97 added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 8, 2024
@janmedrek
Copy link

janmedrek commented Oct 8, 2024

Hey @pPrecel, from KLM's perspective the re-managing of modules is not yet supported, this is rather one-way story until we implement this ticket: kyma-project/lifecycle-manager#1667

Update: re-managing of the modules is supported with a default approach - this means that the whole module deployment will be updated to the current version available in the channel (if multiple module versions were skipped and module introduced some breaking changes it may go bad).

@janmedrek
Copy link

janmedrek commented Oct 9, 2024

We could provide users with such an option, it would be nice to have a clear warning on the risks though:
The re-managed module will be updated to the current active version of the module in the channel. If multiple versions were skipped and breaking changes were introduced in the meantime, the migration may not be automatic and manual adjustments will be needed. Proceed at your own risk.

@mrCherry97
Copy link
Contributor

mrCherry97 commented Oct 9, 2024

Hi @pPrecel
We need to make a few adjustments to the editing modules flow.

Acceptance criteria:

  • add checkbox/switch in Edit view managed/unmanaged
  • label in status should be adjusted to information
  • add warning when the user is trying to save manage to unmanaged change
  • add information when the user is trying to save unmanaged to manage change
  • check why details are not working after setting to unmanaged
  • contact flow with the UXes and decide if we need to use a checkbox or switch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants