Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell completion does not work for Zsh #90

Closed
clebs opened this issue May 24, 2019 · 3 comments
Closed

Shell completion does not work for Zsh #90

clebs opened this issue May 24, 2019 · 3 comments
Assignees
Labels
area/cli Related to all activities around CLI kind/bug Categorizes issue or PR as related to a bug.

Comments

@clebs
Copy link
Contributor

clebs commented May 24, 2019

Description
Following the instructions provided by cobra to enable completion for the kyma CLI commands does not work showing the following error:
/dev/fd/11:type:299: bad option: -t

Expected result

Completions work after running the command as explained by the output of kyma completion -h

Actual result

Error is displayed:
/dev/fd/11:type:299: bad option: -t

Steps to reproduce

  1. Install Kyma CLI as explained here: https://github.com/kyma-project/cli/releases/tag/v0.7.0
  2. Run . <(kyma completion), which should add the completions code to your bash session .
@clebs clebs added area/cli Related to all activities around CLI kind/bug Categorizes issue or PR as related to a bug. labels May 24, 2019
@a-thaler a-thaler added this to the Backlog_Huskies milestone Jun 25, 2019
@a-thaler a-thaler modified the milestones: Backlog_Huskies, Sprint_Huskies_5 Jul 5, 2019
@suleymanakbas91 suleymanakbas91 self-assigned this Jul 17, 2019
@suleymanakbas91
Copy link

Currently, Kyma CLI shell completion does not support Zsh. That's why you see this error. I created a PR to add support but it is blocked by this bug in cobra. As soon as the bug gets fixed (there is already an open PR), I'll merge my PR to provide support for Zsh as well.

@suleymanakbas91 suleymanakbas91 changed the title Bash completion does not work Shell completion does not work for Zsh Jul 17, 2019
@lilitgh lilitgh modified the milestones: Sprint_Huskies_5, Backlog_Huskies Jul 22, 2019
@stale
Copy link

stale bot commented Sep 20, 2019

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 20, 2019
@clebs clebs removed the stale label Sep 20, 2019
@a-thaler a-thaler modified the milestones: Backlog_Huskies, Sprint_Huskies_11 Oct 9, 2019
@suleymanakbas91
Copy link

The bug seems not to be fixed in the near future. We should hard-code the completion code for zsh just like some other clients (e.g. minikube).

@a-thaler a-thaler modified the milestones: Sprint_Huskies_11, Sprint_Huskies_12 Oct 14, 2019
@suleymanakbas91 suleymanakbas91 removed their assignment Oct 17, 2019
@a-thaler a-thaler modified the milestones: Sprint_Huskies_12, Sprint_Huskies_13 Oct 27, 2019
@suleymanakbas91 suleymanakbas91 self-assigned this Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to all activities around CLI kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

4 participants