Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test job for KMC to verify the KMC helm charts and image on PRs #3293

Open
17 tasks
mfaizanse opened this issue Jan 26, 2024 · 1 comment
Open
17 tasks
Labels
area/control-plane Related to all activities around Kyma Control Plane

Comments

@mfaizanse
Copy link
Member

mfaizanse commented Jan 26, 2024

Description

  • Currently, on PRs for KMC, no job tries to deploy KMC and check if everything is fine.
    If you bump a non-existing KMC (or invalid) image in helm chart, then still the PR will be all green.
  • there are no integration tests for integration with KEB and EDP

Task(s):

  • Option 1: Only verify that KMC image exists.

    • Add Github action.
    • Render KCP helm chart with KMC enabled.
    • Extract the KMC image from the rendered manifests.
    • Docker pull to verify if the KMC image is valid.
  • Option 2: Deploy KCP with KMC on k3d and test end-to-end.

    • Add Github action.
    • Create a k3d cluster.
    • Create kcp-system namespace.
    • Create k8s secret (name: kubeconfig-<runtimeId>) with kubeconfig for k3d in kcp-system namespace.
    • mock KEB and EDP, and deploy the mock as a pod in kcp-system namespace..
      • KEB:
        • GET /runtimes --> Returns list of runtimes.
      • EDP:
        • POST /namespaces/kyma-dev/datastreams/kmc-consumption-metrics/1/dataTenants/<tenantId>/dev/events --> Receives event and saves it in-memory.
        • GET /edp/events --> returns all received events/data.
    • Deploy KMC on k3d in kcp-system namespace..
    • Verify if the required data is pushed to mocked EDP.

Acceptance Criteria(s):

  • KMC is tested on PRs.
@mfaizanse mfaizanse added area/eventing Issues or PRs related to eventing area/control-plane Related to all activities around Kyma Control Plane and removed area/eventing Issues or PRs related to eventing labels Jan 26, 2024
@mfaizanse mfaizanse changed the title Add a pre-main test job for KMC to verify the KMC helm charts and image Add a test job for KMC to verify the KMC helm charts and image on PRs Feb 8, 2024
@mfaizanse
Copy link
Member Author

This ticket is blocked until the KMC is moved to its separate repository. Then we can check if option 1 is already covered by the deployment pipelines.

@mfaizanse mfaizanse removed their assignment Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Related to all activities around Kyma Control Plane
Projects
None yet
Development

No branches or pull requests

1 participant