Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ModuleCatalog] Support .spec.info #55

Closed
9 tasks
c-pius opened this issue Oct 1, 2024 · 0 comments · Fixed by #90
Closed
9 tasks

[ModuleCatalog] Support .spec.info #55

c-pius opened this issue Oct 1, 2024 · 0 comments · Fixed by #90
Assignees

Comments

@c-pius
Copy link
Contributor

c-pius commented Oct 1, 2024

Description

Support the info introduced via kyma-project/lifecycle-manager#1841. The module config should be extended with a new field that is than written into .spec.info.

Reasons

Support the info field introduced via kyma-project/lifecycle-manager#1841

Acceptance Criteria

  • When adding entries to module-config.yaml
    info:
      repository: <link>
      documentation: <link>
      icons:
      - name: <string>
        link: <link>
  • Then the entry is written to the generated module template as:
    spec:
      info:
        repository: <link>
        documentation: <link>
        icons:
        - name: <string>
          link: <link>
  • Empty source raises an error (optional in the CRD for compatibility reason, but mandatory in modulectl already)
  • Validations include
    • type <link> must be valid URLs
    • name in icons must be unique
  • Add new field to scaffold command as commented field
  • Cover with unit tests
  • Adapt E2E tests to include new fields

Attachments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants