Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ModuleCatalog] Support .spec.manager #57

Closed
7 tasks done
c-pius opened this issue Oct 2, 2024 · 0 comments · Fixed by #72
Closed
7 tasks done

[ModuleCatalog] Support .spec.manager #57

c-pius opened this issue Oct 2, 2024 · 0 comments · Fixed by #72
Assignees

Comments

@c-pius
Copy link
Contributor

c-pius commented Oct 2, 2024

🚧 field name to be decided, namespace may become optional

Description

Support the manager introduced via kyma-project/lifecycle-manager#1840. The module config should be extended with a new field that is than written into .spec.manager.

Reasons

Support the manager field introduced via kyma-project/lifecycle-manager#1840

Acceptance Criteria

  • Check the correct naming of manager field and adapt accordingly
  • When adding entries to module-config.yaml
    manager:
      group: <group>
      version: <version>
      kind: <kind>
      namespace: <namespace> (optional)
      name: <name>
  • Then the entry is written to the generated module template as:
    spec:
      manager:
        group: <group>
        version: <version>
        kind: <kind>
        namespace: <namespace>
        name: <name>
  • Empty source leads to nothing written
  • Validations in place, share validation code with [ModuleCatalog] Support .spec.associatedResources #54
  • Cover new functionality in unit tests
  • Adapt E2E test to cover new fields

Attachments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants