Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge definitions of shared functions from slack-message-sender and rotate-signify-certificate #11886

Open
3 tasks
KacperMalachowski opened this issue Sep 12, 2024 · 0 comments
Labels
area/quality Related to all activites around quality kind/chore Categorizes issue or PR as related to a chore.

Comments

@KacperMalachowski
Copy link
Contributor

Description

With current repository structure we cannot easily share python code between our cloud runs slack-message-sender and rotate-signify-certificate, because directory structre uses - in the names.

The proposed solution is to remove dashes from directory name, which will be also consistent with pkg directory structure.

Acceptance Criteria

  • Remove dashes from directories names
  • Create common file for get_pubsub_message, preapre_log_fields, prepare_success_response, LogEntry and prepare_error_response python functions and class.
  • Update slack-message-sender and rotate-signify-certificate to use common version of those functions
@KacperMalachowski KacperMalachowski added area/ci Issues or PRs related to CI related topics area/quality Related to all activites around quality kind/chore Categorizes issue or PR as related to a chore. and removed area/ci Issues or PRs related to CI related topics labels Sep 12, 2024
@KacperMalachowski KacperMalachowski changed the title Reorganize folder structure for python code sharing Merge definitions of shared functions from slack-message-sender and rotate-signify-certificate Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/quality Related to all activites around quality kind/chore Categorizes issue or PR as related to a chore.
Projects
None yet
Development

No branches or pull requests

1 participant