test #6
Closed
test #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nadia Pinaeva <[email protected]>
ovnkube-controller and ovnkube-node depend on each other to start up, therefore they are run in parallel. Signed-off-by: Nadia Pinaeva <[email protected]>
ovnkube-controller and ovnkube-node. Fix fake ovn startup order: start watch factory after controller init. Set EnableMultiExternalGateway for tests using abproutes Signed-off-by: Nadia Pinaeva <[email protected]>
failing. The problem is annotation-based and CR-based configs had different BFD settings. Before the change external_gw code always handled annotations before apbroute controller handled CRD, and annotation-based config took place, now with the change CR-based config is applied before. Add 2 explicit test cases for both handling orders to make sure the config will be the same. Signed-off-by: Nadia Pinaeva <[email protected]>
Signed-off-by: Nadia Pinaeva <[email protected]>
kyrtapz
force-pushed
the
test_cm
branch
6 times, most recently
from
02cd51a
to
18280b4
Compare
|
/retest |
1 similar comment
|
/retest |
Changes to metadata via status subresources are not restricted for the basic kubernetes types. This means we can set the status/annotations/labels with only the status subresource permissions. Upstream note: kubernetes/kubernetes#92022 (comment) Signed-off-by: Patryk Diak <[email protected]>
This commit refactors the RBAC rules and serviceAccount ovn-kubernetes uses. Instead of using one ServiceAcoount with one ClusterRole break it down per component. This makes it easier to track which permissions are required by which piece and avoid the mess of granting high privilages to everyone. Signed-off-by: Patryk Diak <[email protected]>
kyrtapz
force-pushed
the
test_cm
branch
2 times, most recently
from
d73a4c8
to
429db59
Compare
|
/retest |
kyrtapz
force-pushed
the
test_cm
branch
2 times, most recently
from
2169684
to
857f423
Compare
On startup each ovnkube-node pod should request a certificate that it will then use to communicate with the API server. This allows to identify which node made a particular request and it is used to implement an admission webhook for write changes. Signed-off-by: Patryk Diak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.