Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translations incomplete #5

Open
l-koehler opened this issue Jan 4, 2024 · 3 comments
Open

translations incomplete #5

l-koehler opened this issue Jan 4, 2024 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@l-koehler
Copy link
Owner

I don't have that much experience with translations, so updating them is going to take a while.
Still totally usable, there is english text for everything that it will fall back to if a translation is broken.
mainly ./ffconverter/dynamictab.py is missing translations.

@l-koehler l-koehler added the bug Something isn't working label Jan 4, 2024
@l-koehler
Copy link
Owner Author

l-koehler commented Jan 4, 2024

does not seem to work at all, the two if conditions here return false even when given valid locales/full paths:
./ffconverter/ffconverter.py 477-483

    locale = QLocale.system().name()
    qtTranslator = QTranslator()
    if qtTranslator.load('qt_' + locale, ':/'):
        app.installTranslator(qtTranslator)
    appTranslator = QTranslator()
    if appTranslator.load('ffconverter_' + locale, ':/'):
        app.installTranslator(appTranslator)

The same thing does work in https://github.com/ilstam/FF-Multi-Converter, so it should be easy to fix

@l-koehler
Copy link
Owner Author

fixed the translations not working at all (d8c6098), now they are just incomplete.

@l-koehler l-koehler changed the title translations partially broken translations incomplete Jan 4, 2024
@l-koehler
Copy link
Owner Author

be30272 updated german translation which is now complete. all other translations are still incomplete (english is complete, as it is the language this is developed in).

@l-koehler l-koehler added enhancement New feature or request help wanted Extra attention is needed and removed bug Something isn't working labels Jan 4, 2024
@l-koehler l-koehler pinned this issue Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant