No way to set solid background colour

[sidequestboy]

The code at (SetBG::set_bg on master, SetBG::set_bgon setter_refactor) doesn't allow for a simple interface to set the background to a solid colour with no image file.

UI symptoms:

• Cannot set solid color to background from GUI
• Cannot set solid color without specifying a (transparent?) image file from command line using --set-color

[sidequestboy]

I think the best thing to do is to modify (SetBG::set_bg on master, SetBG::set_bgon setter_refactor) to decouple the setting of the background colour from the setting of the background image.

This might be useful in the future if you wanted to allow setting solid colours in the GUI, or handle the --set-color without a filename, and here to set a fallback background colour.

That doesn't seem to me to be a matter of simple hacking though. (I'm not familiar with what's going on with pixbufs, colormaps, windows, screens...)

But I do see that your SetBG::make_ functions (here on master, here on setter_refactor) set the background colour with

orig->fill(GdkColorToUint32(bgcolor))

So, if they called a function like this one:

/**
 * Copies and returns pixbuf with bgcolor filled.
 * 
 * @param   orig    The original pixbuf
 * @param   bgcolor The colour to fill background with
 */
Glib::RefPtr<Gdk::Pixbuf> SetBG::fill_colour(const Gdk::Pixbuf orig,
    Gdk::Color bgcolor) {
    Glib::RefPTr<Gdk::Pixbuf> retval = orig->fill(GdkColorToUint32(bgcolor));
    return retval;
}

and we had a function called e.g.

bool SetBG::set_bg_colour(Glib::ustring &disp, Gdk::Color bgcolor);

that did the same stuff as SetBG::set_bg, but with calling this fill_colour function.

or if we hacked the current SetBG::set_bg to handle a "solid color" mode,

that would solve the problem.

[sidequestboy]

void Gdk::Window::set_background(const Color& color)

[RichJack]

Has this been implemented yet in any of the builds here on GitHub? I'm using build 1.5.2-2 in Ubuntu 14.04 and I have to use a transparent png to set a solid background color... Thanks