Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segmentation fault in SphericalCovariants for covariant_lambda=0 #392

Open
bananenpampe opened this issue Nov 17, 2021 · 2 comments
Open
Labels
bug Something isn't working

Comments

@bananenpampe
Copy link

Hello everyone,

calling the SphericalCovariants function with covariant_lambda=0 results in a segmentation fault.

#load some wrapped training structures

hypers = {"soap_type": "LambdaSpectrum",
          "interaction_cutoff": 3,
          "radial_basis": "GTO",
          "max_radial": 9,
          "max_angular": 9,
          "gaussian_sigma_constant": 0.3,
          "gaussian_sigma_type":"Constant",
          "cutoff_function_type":"ShiftedCosine",
          "cutoff_smooth_width": 0.5,
          "normalize": True,
          "cutoff_function_parameters":dict(rate=1,scale=3.5,exponent=4),
          "covariant_lambda":0
         }

calculator = SphericalCovariants(**hypers)
X_train = calculator.transform(train_structures).get_features(calculator)

The relevant gdb output is:

Thread 1 "python" received signal SIGSEGV, Segmentation fault.
0x00007fffcc99365b in void rascal::CalculatorSphericalCovariants::compute_impl<(rascal::internal::SphericalCovariantsType)0, 0, rascal::AdaptorStrict<rascal::AdaptorCenterContribution<rascal::AdaptorNeighbourList<rascal::StructureManagerCenters> > > >(std::shared_ptr<rascal::AdaptorStrict<rascal::AdaptorCenterContribution<rascal::AdaptorNeighbourList<rascal::StructureManagerCenters> > > >) ()

@Luthaf Luthaf added the bug Something isn't working label Nov 17, 2021
@agoscinski
Copy link
Contributor

agoscinski commented Nov 30, 2021

are you (@max-veit @Luthaf) okay with a fix to throw error when covariant_lambda=0? I doubt that anyone will fix the real underlying error. We can refer to the python implementation which seems to be now the standard (? @curiosity54). It's also not horrible slow if the number structures is decently large.

@Luthaf
Copy link
Contributor

Luthaf commented Nov 30, 2021

We also discussed removing SphericalCovariants altogether at some point, suggesting users to use the Python-only version when then try to import it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants