Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silent failure of DockerAgent.push_image() due to absense of exception handling #2569

Open
jopemachine opened this issue Jul 26, 2024 · 0 comments · May be fixed by #2572
Open

Silent failure of DockerAgent.push_image() due to absense of exception handling #2569

jopemachine opened this issue Jul 26, 2024 · 0 comments · May be fixed by #2572
Assignees
Labels
comp:agent Related to Agent component

Comments

@jopemachine
Copy link
Member

jopemachine commented Jul 26, 2024

What Operating System(s) are you seeing this problem on?

Linux (x86-64)

Backend.AI version

main

Describe the bug

If the credential information or access token is incorrect, DockerAgent.push_image() fails, but the session export process is still marked as completed successfully on the terminal.

❯ ./backend.ai session convert-to-image dae2abe4-63a0-4ca9-9530-6a35643e965a test
∙ Request to commit Session(name or id: dae2abe4-63a0-4ca9-9530-6a35643e965a)
✓ Session export process completed.

await docker.images.push(image_ref.canonical, auth=auth_config)

For example, when DockerAgent.push_image() fails, you can tell that the request failed from the following output.

However, the user is informed that the session commit request was successful, and no error messages are displayed on the manager or agent consoles.

# Print the response value of push_image to the terminal
[{'status': ...  
{'status': 'Waiting', 'progressDetail': {}, 'id': '2a81f40e5b59'}, {'status': 'Waiting', 'progressDetail': {}, 'id': '9f54eef41275'}, 
{'errorDetail': {'message': 'denied: Your Authorization Token is invalid.'}, 'error': 'denied: Your Authorization Token is invalid.'}]

To Reproduce

Committing the session after recording an incorrect value in the password

Expected Behavior

A success message should only be displayed in the case of success.

Anything else?

No response

@jopemachine jopemachine added the type:bug Reports about that are not working label Jul 26, 2024
@jopemachine jopemachine changed the title Silent failure when push_image failed Silent failure of DockerAgent.push_image() due to absense of exception handling Jul 26, 2024
@jopemachine jopemachine added the comp:agent Related to Agent component label Jul 26, 2024
@jopemachine jopemachine self-assigned this Jul 26, 2024
@jopemachine jopemachine linked a pull request Jul 26, 2024 that will close this issue
3 tasks
@achimnol achimnol removed the type:bug Reports about that are not working label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:agent Related to Agent component
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants