Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve log handling #3034

Open
HyeockJinKim opened this issue Nov 6, 2024 · 0 comments
Open

Improve log handling #3034

HyeockJinKim opened this issue Nov 6, 2024 · 0 comments
Labels
effort:easy Need to understand only a specific region of codes (good first issue, easy).
Milestone

Comments

@HyeockJinKim
Copy link

Main idea

References

Motivation

  1. When db or etcd is terminated, the manager continues to retry the connection. However, in this case, an exception message is displayed instead of a log.
  2. When the redis connection is terminated and the manager retries the connection, there is no log indicating when the connection is successfully restored. It is difficult to explicitly know the time of redis reconnection.

Tasks

  1. Ensure that an exception is logged when PostgreSQL or etcd connection retries fail.
  2. When a redis request is retried and successfully completes, log the successful retry event as an info log.
    • I think it would be better to run a ping request periodically to track the status of the redis server.

Expected Results

  • Consistent logging of both failure and recovery events, making it easier to track the issues and their resolutions.

Alternative ideas

No response

Anything else?

No response

@HyeockJinKim HyeockJinKim added the effort:easy Need to understand only a specific region of codes (good first issue, easy). label Nov 6, 2024
@HyeockJinKim HyeockJinKim added this to the 24.12 milestone Nov 6, 2024
@HyeockJinKim HyeockJinKim changed the title Improve Log Handling Improve log handling Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:easy Need to understand only a specific region of codes (good first issue, easy).
Projects
None yet
Development

No branches or pull requests

1 participant