Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can someone merge my pull request? #2678

Closed
IsusRamzy opened this issue Sep 9, 2024 · 2 comments
Closed

Can someone merge my pull request? #2678

IsusRamzy opened this issue Sep 9, 2024 · 2 comments

Comments

@IsusRamzy
Copy link

I made a pull request (#2673).
It will include HTML templates engine built-in for Echo.
The current way to make a template is not user-friendly and takes lots of lines.
I'm a beginner here, but I have some knowledge in Flask.
In Flask, render_template is builtin, I can import it and use it without many lines.
@IsusRamzy
Copy link
Author

?

@martinyonatann
Copy link
Contributor

your PR have some comment from maintainer

@aldas aldas closed this as completed Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aldas @martinyonatann @IsusRamzy