Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib-finding code should search package/lib first before searching system PATH #37

Closed
cboulay opened this issue Oct 9, 2020 · 1 comment

Comments

@cboulay
Copy link
Contributor

cboulay commented Oct 9, 2020

The lib finding code iterates through all possible combinations of library naming schemes. For each prefix-suffix combination, it first attempts the local dir then it attempts the system paths before moving on to the next combination.

I think this is the reason why more errors were reporting DLL errors with pylsl recently: it was finding old liblsl(32|64).dll on the PATH before it reached the correct naming scheme for the dll that's in the package/lib dir.

This should be changed so that it first searches through all combinations in the package/lib dir, then if that fails it searches at the system level. This requires a small refactor to so as to not duplicate the search code.

If someone else is in the mood to do that then you are more than welcome. Otherwise I'll add it to my lossy queue.

@cboulay
Copy link
Contributor Author

cboulay commented Nov 10, 2020

Fixed in ba94136

@cboulay cboulay closed this as completed Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant