Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update failing test from API changes #261

Closed
afiune opened this issue Dec 10, 2020 · 1 comment · Fixed by #262 or #368
Closed

Update failing test from API changes #261

afiune opened this issue Dec 10, 2020 · 1 comment · Fixed by #262 or #368
Assignees
@afiune
Labels
bug Something isn't working ci Continuous Integration

Comments

@afiune
Copy link
Contributor

afiune commented Dec 10, 2020 •
edited
Loading

The API server was updated yesterday and one of our integration tests is failing:

=== RUN   TestHostVulnerabilityCommandShowAssessment/verifying_table_headers
    host_vulnerability_test.go:154: 
        	Error Trace:	host_vulnerability_test.go:154
        	Error:      	"               HOST DETAILS              |         VULNERABILITIES           
        	            	-----------------------------------------+-----------------------------------
        	            	    Machine ID   30                      |    SEVERITY    COUNT   FIXABLE    
        	            	    Hostname     circle-ci-test-node     | -------------+-------+----------  
        	            	    External IP  34.210.84.26            |   Critical         0         0    
        	            	    Internal IP  10.0.1.170              |   High             8         8    
        	            	    Os           linux                   |   Medium          36        36    
        	            	    Arch         amd64                   |   Low              4         4    
        	            	    Namespace    amzn:2                  |   Negligible       0         0    
        	            	    Provider     AWS                     |                                   
        	            	    Instance ID  i-0fe9eee01057140c5     |                                   
        	            	    AMI          ami-0528a5175983e7f28   |                                   
        	            	                                         |                                   
        	            	Try adding '--details' to increase details shown about the vulnerability assessment.
        	            	" does not contain "Hostname     ip-10-0-1-170.us-west-2.compute.internal"
        	Test:       	TestHostVulnerabilityCommandShowAssessment/verifying_table_headers
        	Messages:   	STDOUT table does not contain the 'Hostname     ip-10-0-1-170.us-west-2.compute.internal' output

We need to update the Hostname from our CircleCI test node.

Failing job: https://circleci.com/gh/lacework/go-sdk/2788
@afiune afiune added bug Something isn't working ci Continuous Integration labels Dec 10, 2020
@afiune afiune self-assigned this Dec 10, 2020
afiune added a commit that referenced this issue Dec 10, 2020
@afiune
ci: update hostname from our test machine
03bfa2a 
Closes #261
@afiune afiune mentioned this issue Dec 10, 2020
Merged
afiune added a commit that referenced this issue Dec 10, 2020
@afiune
ci: update hostname from our test machine (#262)
beb289e 
Closes #261
@afiune afiune reopened this Dec 11, 2020
afiune added a commit that referenced this issue Dec 11, 2020
@afiune
ci: flacky integration test for host vuln
004b429 
Re-opens #261

Signed-off-by: Salim Afiune Maya <[email protected]>
@afiune
Copy link
Contributor Author

afiune commented Dec 11, 2020

Unfortunately, this is still an issue: https://app.circleci.com/pipelines/github/lacework/go-sdk/784/workflows/8d169f60-261d-4bef-ae1c-5d8c4324d490/jobs/2816

afiune added a commit that referenced this issue Dec 11, 2020
@afiune
ci: flacky integration test for host vuln
d003835 
Re-opens #261

Signed-off-by: Salim Afiune Maya <[email protected]>
@afiune afiune closed this as completed Apr 2, 2021
@afiune afiune reopened this Apr 2, 2021
afiune added a commit that referenced this issue Apr 2, 2021
@afiune
test(integration): fix failing test from API changes
5aadead 
Closes #261

Signed-off-by: Salim Afiune Maya <[email protected]>
@afiune afiune mentioned this issue Apr 2, 2021
Merged
afiune added a commit that referenced this issue Apr 5, 2021
@afiune
test(integration): fix failing test from API changes (#368)
57b33e3 
Closes #261

Signed-off-by: Salim Afiune Maya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afiune afiune

Labels
bug Something isn't working ci Continuous Integration
Projects
None yet
Milestone
No milestone
1 participant
@afiune