fix(cdk): Avoid double component error messages #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Current Behavior:** When running a component, if the component fails, we print two error messages: ``` $ lacework iac fdsasd Error: unknown command "fdsasd" for "iac" ERROR unable to run component: exit status 1 ``` **New Behavior:** We detect that the error is a component failing to run and we avoid outputting two error messages: ``` $ lacework iac fdsasd Error: unknown command "fdsasd" for "iac" ``` Signed-off-by: Salim Afiune Maya <[email protected]>
hazedav
approved these changes
Nov 2, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Current Behavior:
When running a component, if the component fails, we print two error messages:
New Behavior:
We detect that the error is a component failing to run and we avoid outputting two error messages:
Signed-off-by: Salim Afiune Maya [email protected]
How did you test this change?
Ran manually both, component and non-component commands.
Issue
https://lacework.atlassian.net/browse/ALLY-1259