Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GROW-2876): support terraform output blocks in lwgenerate #1609

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

ipcrm
Copy link
Contributor

@ipcrm ipcrm commented Apr 8, 2024

Summary

  • Add generic functionality for hcl output blocks
  • Add hooks to AWS to add outputs

Outputs are arbitrary, meaning the author needs to understand the resultant traversal (and that it is valid) otherwise the resultant code will be unusable.

How did you test this change?

Unit tests

Issue

https://lacework.atlassian.net/browse/GROW-2876

* Add generic functionality for hcl output blocks
* Add hooks to AWS to add outputs

Outputs are arbitrary, meaning the author needs to understand the
resultant traversal (and that it is valid) otherwise the resultant code
will be unusable.
@ipcrm ipcrm requested a review from a team as a code owner April 8, 2024 20:34
@ipcrm ipcrm force-pushed the ipcrm/GROW-2876/lwgenerate-support-outputs branch from 81b5eec to 894814b Compare April 8, 2024 23:18
@ipcrm ipcrm merged commit 5440c57 into main Apr 9, 2024
11 checks passed
@ipcrm ipcrm deleted the ipcrm/GROW-2876/lwgenerate-support-outputs branch April 9, 2024 17:31
@lacework-releng lacework-releng mentioned this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants