refactor: account mapping file for consolidated CT #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactor is modifying the behavior of the Encode and Decode functions to use `[]byte` instead of `string`, this way we won't be casting its content back and forth like this example: lacework/terraform-provider-lacework#43 Additionally, I have made the `lacework integration show` command to display the account mapping content. ``` $ lacework int show TECHALLY_53DFFB3E788A30BD84AD1822B06473018B2B4CBA0C1AD4C INTEGRATION GUID | NAME | TYPE | STATUS | STATE -----------------------------------------------------------+--------------------------------+------------+---------+-------- TECHALLY_53DFFB3E788A30BD84AD1822B06473018B2B4CBA0C1AD4C | A consolidated CloudTrail | AWS_CT_SQS | Enabled | Ok INTEGRATION DETAILS ---------------------------------------------------------------------------------------------------------- ROLE ARN | arn:aws:iam::123483698038:role/lacework_iam_role EXTERNAL ID | bubulubu QUEUE URL | https://sqs.us-west-2.amazonaws.com/123483698038/lacework-ct-sqs-tech-ally ACCOUNT MAPPING FILE | { | "defaultLaceworkAccountAws": "mini-ally", | "integration_mappings": { | "customerdemo": { | "aws_accounts": [ | "934534535", | "553453453" | ] | }, | "tech-ally": { | "aws_accounts": [ | "774564564", | "234556677" | ] | } | } | } UPDATED AT | 2020-Nov-24 14:05:58 UTC UPDATED BY | [email protected] STATE UPDATED AT | 2020-Nov-24 14:06:02 UTC LAST SUCCESSFUL STATE | 2020-Nov-24 14:06:02 UTC ``` Signed-off-by: Salim Afiune Maya <[email protected]>
afiune
added
cli
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor is modifying the behavior of the Encode and Decode
functions to use
[]byteinstead ofstring, this way we won't becasting its content back and forth like this example:
lacework/terraform-provider-lacework#43
Additionally, I have made the
lacework integration showcommand todisplay the account mapping content.
Signed-off-by: Salim Afiune Maya [email protected]