feat: Add List Azure Tenants command #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darren Murray <[email protected]>
Signed-off-by: Darren Murray <[email protected]>
afiune
suggested changes
Mar 16, 2021
cli/cmd/compliance_azure.go
Outdated
| Long: `List all Azure Tenants.`, | ||
| Args: cobra.NoArgs, | ||
| RunE: func(_ *cobra.Command, _ []string) error { | ||
| response, err := cli.LwApi.Compliance.ListAzureTenants() |
There was a problem hiding this comment.
Interesting way to do this but, I'm afraid it doesn't follow the standard we put in compliance for AWS. Also, we are creating "an API that doesn't exist in the platform itself" and that goes against the principle to match 100% the Lacework API. I think we should add this functionality to the CLI alone, just like the command to list AWS accounts.
Signed-off-by: Darren Murray <[email protected]>
afiune
suggested changes
Mar 16, 2021
cli/cmd/compliance_azure.go
Outdated
| } | ||
|
|
||
| if cli.JSONOutput() { | ||
| return cli.OutputJSON(response.Data[0]) |
There was a problem hiding this comment.
If an account doesn't have any Azure CFG integrations, we will panic here!
lacework comp az list --json -p mini
panic: runtime error: index out of range [0] with length 0
goroutine 1 [running]:
github.com/lacework/go-sdk/cli/cmd.glob..func8(0x1d49f80, 0xc0004fcf60, 0x0, 0x3, 0x0, 0x0)
/Users/salimmaya/go/src/github.com/lacework/go-sdk/cli/cmd/compliance_azure.go:85 +0x48f
github.com/spf13/cobra.(*Command).execute(0x1d49f80, 0xc0004fcf30, 0x3, 0x3, 0x1d49f80, 0xc0004fcf30)
/Users/salimmaya/go/src/github.com/lacework/go-sdk/vendor/github.com/spf13/cobra/command.go:842 +0x47c
github.com/spf13/cobra.(*Command).ExecuteC(0x1d4cc20, 0x16529cc, 0xc000607700, 0x1d58b22)
/Users/salimmaya/go/src/github.com/lacework/go-sdk/vendor/github.com/spf13/cobra/command.go:950 +0x375
github.com/spf13/cobra.(*Command).Execute(...)
/Users/salimmaya/go/src/github.com/lacework/go-sdk/vendor/github.com/spf13/cobra/command.go:887
github.com/lacework/go-sdk/cli/cmd.Execute(0x0, 0x0)
/Users/salimmaya/go/src/github.com/lacework/go-sdk/cli/cmd/root.go:100 +0x85
main.main()
/Users/salimmaya/go/src/github.com/lacework/go-sdk/cli/main.go:29 +0x26
Signed-off-by: Salim Afiune Maya <[email protected]>
afiune
force-pushed
the
dmurray-lacework/az-tenants
branch
from
785bbd5
to
515ad42
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new command to list Azure Tenants
Usage:
$ lacework compliance azure list-tenantsOutput:
Signed-off-by: Darren Murray [email protected]