Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): Json result adheres to filters for cmd get-report (aws,gcp,azure) #379

Merged
merged 2 commits into from
Apr 13, 2021
Merged

fix(cli): Json result adheres to filters for cmd get-report (aws,gcp,azure) #379

merged 2 commits into from
Apr 13, 2021

Conversation

dmurray-lacework
Copy link
Collaborator

@dmurray-lacework dmurray-lacework commented Apr 9, 2021 •
edited
Loading

Fix json output to should work in combination with any filtering flags

  • az get-report compliance_azure.go:191
  • gcp get-report compliance_gcp.go:155
  • aws get-report compliance_aws.go:162

Signed-off-by: Darren Murray [email protected]

@afiune afiune requested a review from a team April 13, 2021 04:33
@afiune afiune added the bug Something isn't working label Apr 13, 2021
afiune
afiune approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tenor-173611466

@afiune afiune changed the title fix: Json result adheres to filters for cmd get-report(aws,gcp,azure) fix(cli): Json result adheres to filters for cmd get-report (aws,gcp,azure) Apr 13, 2021
@dmurray-lacework dmurray-lacework merged commit 0da3db3 into main Apr 13, 2021
@dmurray-lacework dmurray-lacework deleted the dmurray-lacework/fix-json-output branch April 13, 2021 09:19
@afiune afiune mentioned this pull request Apr 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afiune afiune afiune approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmurray-lacework @afiune