Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Manage Alert Rules in Lacework CLI #597

Merged
merged 7 commits into from
Nov 4, 2021

Conversation

dmurray-lacework
Copy link
Collaborator

@dmurray-lacework dmurray-lacework commented Oct 29, 2021

Summary

Manage Alert Rules in the Lacework cli

How did you test this change?

New integration tests integration/alert_rules_test.go
Manually run lacework alert-rule create | list | show | delete

Issue

https://lacework.atlassian.net/browse/ALLY-681

@dmurray-lacework dmurray-lacework marked this pull request as ready for review November 1, 2021 17:57
@dmurray-lacework dmurray-lacework requested a review from a team November 2, 2021 15:29
@afiune afiune changed the title feat(cli): Manage Alert Rules in Lacework cli feat(cli): Manage Alert Rules in Lacework CLI Nov 2, 2021
Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

tenor-187130103

cli/cmd/alert_rules.go Outdated Show resolved Hide resolved
cli/cmd/alert_rules.go Outdated Show resolved Hide resolved
cli/cmd/alert_rules.go Outdated Show resolved Hide resolved
cli/cmd/alert_rules.go Outdated Show resolved Hide resolved
cli/cmd/alert_rules.go Outdated Show resolved Hide resolved
cli/cmd/alert_rules.go Outdated Show resolved Hide resolved
cli/cmd/alert_rules.go Outdated Show resolved Hide resolved
cli/cmd/alert_rules.go Outdated Show resolved Hide resolved
cli/cmd/alert_rules.go Outdated Show resolved Hide resolved
cli/cmd/alert_rules.go Outdated Show resolved Hide resolved
cli/cmd/alert_rules.go Outdated Show resolved Hide resolved
cli/cmd/alert_rules.go Show resolved Hide resolved
cli/cmd/alert_rules.go Outdated Show resolved Hide resolved
cli/cmd/alert_rules.go Outdated Show resolved Hide resolved
Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tenor-18739220

@dmurray-lacework dmurray-lacework merged commit 4d5648c into main Nov 4, 2021
@dmurray-lacework dmurray-lacework deleted the dmurray-lacework/ALLY-681 branch November 4, 2021 16:04
@lacework-releng lacework-releng mentioned this pull request Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants