feat(api): implement crud operations for team members #614
Conversation
api/team_members.go
Outdated
| if userEnabledEnum > 1 || userEnabledEnum < 0 { | ||
| return TeamMember{}, errors.New("userEnabled field must be 0 for disabled or 1 for enabled") | ||
| } |
There was a problem hiding this comment.
We talked about this over in standup, lets stick with numbers and set it to 1 (enabled) by default.
| err = errors.New("please specify a guid") | ||
| return | ||
| } | ||
| err = svc.client.RequestEncoderDecoder("PATCH", fmt.Sprintf(apiV2TeamMembersFromGUID, tm.UserGuid), tm, &res) |
There was a problem hiding this comment.
For updates, verify that you are able to send the UserGuid as part of the request payload, some endpoints complain about it since you are already injecting it via URL parameter.
api/team_members.go
Outdated
| // Delete deletes a single team member with the corresponding guid | ||
| func (svc *TeamMembersService) Delete(guid string) error { | ||
| if guid == "" { | ||
| errors.New("please specify a guid") |
There was a problem hiding this comment.
| errors.New("please specify a guid") | |
| return errors.New("please specify a guid") |
api/team_members.go
Outdated
| Company string `json:"company"` | ||
| CreatedTime string `json:"createdTime,omitempty"` | ||
| FirstName string `json:"firstName"` | ||
| JitCreated bool `json:"jitCreated,omitempty"` |
There was a problem hiding this comment.
@afiune @dmurray-lacework I'm worried about a couple fields here that are strings but the API returns integers. For example here is the API response for getting a single team member. { "data": { "custGuid": "<redacted>", "props": { "accountAdmin": true, "company": "CUSTOMERDEMO", "createdTime": "2020-04-09T17:39:51.572Z", "firstName": "<redacted>", "jitCreated": false, "lastName": "<redacted>", "lastSessionCreatedTime": 0, "orgAdmin": true, "orgUser": false, "updatedTime": 0 }, "userEnabled": 1, "userGuid": "<redacted>", "userName": "<redacted>" } }
How should we handle the API returning ints for lastSessionCreatedTime and updatedTime? I suspect that we're going to have issues deserializing.
There was a problem hiding this comment.
It seems when something hasn't been updated updatedTime/lastSessionCreatedTime returns as 0(int) but when populated it returns as string time stamp. "updatedTime": "2021-02-25T15:25:01.691Z".
This may not actually cause any issues. int value will fail to deserialize, but updatedTime/lastSessionCreatedTime would be empty strings anyway. But would be good to test this to confirm.
| LastSessionCreatedTime: "0", | ||
| OrgAdmin: false, | ||
| OrgUser: false, | ||
| UpdatedTime: "0", |
There was a problem hiding this comment.
From the comment above would this not be an int of 0. And for scenarios when the member has been updated it would be a string timestamp like CreatedTime "2021-11-16T16:33:17.573Z"
api/team_members_test.go
Outdated
| "lastSessionCreatedTime": "0", | ||
| "orgAdmin": false, | ||
| "orgUser": false, | ||
| "updatedTime": "0" |
There was a problem hiding this comment.
from what @dmurray-lacework already mentioned, what happens if this field is 0?
"updatedTime": 0
Summary
Implement team members.
How did you test this change?
There are some new tests.
Issue
https://lacework.atlassian.net/browse/ALLY-736