feat(api): Vulnerability Exceptions v2 Service #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmurray-lacework
force-pushed
the
dmurray-lacework/ALLY-749
branch
from
f58344d
to
c95c4b7
Compare
dmurray-lacework
force-pushed
the
dmurray-lacework/ALLY-749
branch
4 times, most recently
from
ff20fe8
to
d097918
Compare
afiune
reviewed
Dec 14, 2021
afiune
reviewed
Dec 14, 2021
afiune
reviewed
Dec 14, 2021
afiune
reviewed
Dec 14, 2021
afiune
reviewed
Dec 14, 2021
afiune
reviewed
Dec 14, 2021
dmurray-lacework
force-pushed
the
dmurray-lacework/ALLY-749
branch
from
1e6dc85
to
89022ce
Compare
afiune
reviewed
Dec 20, 2021
afiune
reviewed
Dec 20, 2021
| } | ||
|
|
||
| // Create creates a single Vulnerability Exception | ||
| func (svc *VulnerabilityExceptionsService) Create(vuln VulnerabilityException) ( |
There was a problem hiding this comment.
I would suggest removing Create() and Update() functions since we have specific functions for every type and that way we will follow a pattern.
afiune
approved these changes
Jan 6, 2022
Signed-off-by: Darren Murray <[email protected]>
dmurray-lacework
force-pushed
the
dmurray-lacework/ALLY-749
branch
from
748aed0
to
1587a1f
Compare
Signed-off-by: Darren Murray <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Darren Murray [email protected]
Summary
New Vulnerability Exceptions service added to go-sdk .
How did you test this change?
api/vulnerability_exceptions_test.go
api/examples/vulnerability-exceptions/main.go
Issue
https://lacework.atlassian.net/browse/ALLY-749