fix(api): add newResponse for function SearchAllPages #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afiune
changed the title
|
Make it so! |
|
@aircraft-cerier Thank you so much for your first contribution to this project! 🎉 I think this update makes sense and it will help us fix the bug you are experiencing, but for us to merge this change we need two things:
Please let us know if you need any help with these two requests. We look forward to merging this pull request! 💯 |
aircraft-cerier
force-pushed
the
main
branch
2 times, most recently
from
fb3f038
to
602a3a3
Compare
|
@afiune I think i fixed your 2 requests, let me know if i'm missing something |
|
Make it so! |
rmoles
approved these changes
May 4, 2022
|
Hi @aircraft-cerier I see one of your commits is still missing the "verified" icon. Can you do a rebase, then push with a signed commit. |
aircraft-cerier
force-pushed
the
main
branch
5 times, most recently
from
a794936
to
e020fad
Compare
|
Make it so! |
This is necessary as using the current response to iterate over pages corrupts data that are slices, such as the tags within imageInfo. This is beacause the memory address from the previous response will still contain data from the previous request. By creating a new response using the nextPage url we get a new spot in memory to put the next requests data. Signed-off-by: aircraft-cerier <[email protected]>
This is necessary as using the current response to iterate over pages corrupts data that are slices, such as the tags within imageInfo. This is beacause the memory address from the previous response will still contain data from the previous request. By creating a new response using the nextPage url we get a new spot in memory to put the next requests data. Signed-off-by: aircraft-cerier <[email protected]>
Signed-off-by: aircraft-cerier <[email protected]>
Signed-off-by: aircraft-cerier <[email protected]>
Signed-off-by: aircraft-cerier <[email protected]>
|
Make it so! |
dmurray-lacework
approved these changes
May 5, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary as using the current response to iterate over pages
corrupts data that are slices, such as the tags within imageInfo. This is because
the memory address from the previous response will still contain data from the previous request.
By creating a new response using the nextPage url we get a new spot in memory to put the next
requests data.